Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - IOU - Currency symbol and amount in BNP are mostly truncated #3964

Closed
kavimuru opened this issue Jul 9, 2021 · 7 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Lunch the app
  2. Log in with any account
  3. Click on Green Button
  4. Click Spit/ Request Money

Expected Result:

Currency and amount symbol should be full visible in the BNP page

Actual Result:

Currency symbol and amount are cut off in the BNP page

Workaround:

Visual issue

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number:
1.0.77-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5146062_Screenshot_20210709-190618_Expensifycash

Bug5146062_Screen_Recording_20210709-190622_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jul 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

We just replaced all uses of Text from react-native to our custom Text component and this is a side effect of that change. So the best solution would be to determine all the places where text is chopped and fix it in a PR.

@roryabraham
Copy link
Contributor

this is a side effect of that change

Because it defines a default lineHeight?

@roryabraham
Copy link
Contributor

Okay, this is a regression I caused, so I can have a PR up in just a few minutes.

@Dal-Papa
Copy link

Assigning @roryabraham for reference but this should be closed soon.

@isagoico
Copy link

isagoico commented Jul 13, 2021

Confirmed this is fixed in Android 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants