Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper reportID for chatReport after creating IOU #3946

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Jul 9, 2021

Details

This fixes an issue where the chatReportID for an IOUReport was being set incorrectly after creating a new IOU transaction.

Fixed Issues

$ #3940

Tests/QA

  1. Log in with any account
  2. Click on Green button and click on Split
  3. Put amount and click next
  4. Select couple users and click next
  5. After Split Request is done select user which you requested money.
  6. Click on Badge in the header
  7. Confirm payment details are shown
  8. Click on a single user's chat and request money from them via the + button in the compose box
  9. Request money and then click on the badge, confirm the payment details are shown

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Single Request Split Bill

@Jag96 Jag96 self-assigned this Jul 9, 2021
@Jag96 Jag96 requested a review from a team as a code owner July 9, 2021 05:04
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team July 9, 2021 05:05
@joelbettner joelbettner merged commit 2442240 into main Jul 9, 2021
@joelbettner joelbettner deleted the joe-fix-iou-details branch July 9, 2021 18:01
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

@Jag96 Should we CP this to staging?

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 9, 2021

This issue has existed for quite a while but if we want to avoid it being blocked on the rest of the deploy checklist then yeah I think this is fine to CP to staging.

@roryabraham
Copy link
Contributor

This was deployed to staging in 1.0.76-3

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants