Switch async-storage repository #3898
Conversation
There was a problem hiding this comment.
I've enabled the next AsyncStorage version
https://react-native-async-storage.github.io/async-storage/docs/advanced/next
I can revert the changes if you prefer
Can't really see any differences in app speeds with either the "old" async storage, the "new" and the "new + next"
package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "react-native-image-picker": "^4.0.3", | |||
| "react-native-keyboard-spacer": "^0.4.1", | |||
| "react-native-modal": "^11.10.0", | |||
| "react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#1e82e592032c6d0ede8e40f08beb6be790d149e8", | |||
| "react-native-onyx": "git+https://github.com/kidroca/react-native-onyx.git#064748fdc6ceef7c9ffe8c5fa62a30ef234aae2a", | |||
There was a problem hiding this comment.
This hash should be updated after the Onyx PR is merged
|
Cool, thanks! I think trying out the |
| @@ -38,7 +38,7 @@ | |||
| "@formatjs/intl-numberformat": "^6.2.5", | |||
| "@formatjs/intl-pluralrules": "^4.0.13", | |||
| "@onfido/react-native-sdk": "^1.3.3", | |||
| "@react-native-community/async-storage": "^1.11.0", | |||
| "@react-native-async-storage/async-storage": "^1.15.5", | |||
There was a problem hiding this comment.
Hm, so why are we installing this lib directly? I'm not sure why the previous lib was referenced here either. AFAIK, the only way we should be interfacing with AsyncStorage is through Onyx.
There was a problem hiding this comment.
I'm not seeing it directly imported into any files, so can this just be removed?
There was a problem hiding this comment.
This is related to the comment I've made on peerDependencies on the other PR
We need to have it listed as a project dependency
We also have one place where it's imported - inside mocks
The e2e tests that use Onyx stub AsyncStorage from E.cash mocks
|
I've put this comment on the wrong place, so I'm posting it again here I've run the 3 version against E.cash and here is a short summary Median times for 7 app startups per each AsyncStorage version
Timing for
|
| 1.12.1 | 1.15.5 | 1.15.5 next | |
|---|---|---|---|
| avg call time | 131.55ms | 140.95ms | 134.90ms |
| total call time | 32862.34ms | 35175.71ms | 33552.87ms |
| total calls count | 529 | 529 | 529 |
- note: a lot of the calls are resolved from Onyx cache, the actual hard reads vary from 200 to 1000ms
More data is available here:
https://docs.google.com/spreadsheets/d/1ABHCzs9yZIXmHxMJnDboyyMw8ICjQQ3sxIP_23c7Lws/edit?usp=sharing
tgolen
changed the title
|
This is approved, but I am adding a |
|
Updated |
tgolen
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production in version: 1.0.77-5🚀
|
Details
The package @react-native-community/async-storage is deprecated from @react-native-community repo
It's moved and maintained as @react-native-async-storage/async-storage
There are some improvements that have happened since then
There are no breaking changes listed
This PR needs to be updated with the correct Onyx hash Expensify/react-native-onyx#85 is merged
Fixed Issues
Related to #2667
Tests
Since storage affects everything a general tests for regressions should be carried
QA Steps
Since storage affects everything a general tests for regressions should be carried
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android