Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Workspace Policy Avatars #3933

Merged
merged 8 commits into from
Jul 8, 2021
Merged

Add Workspace Policy Avatars #3933

merged 8 commits into from
Jul 8, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 8, 2021 •
edited
Loading

Details

Adds the ability to give a workspace an avatar. Slight refactor of the Profile settings page avatar.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169741

Tests

QA Steps

  1. Navigate to /settings/profile
  2. Verify there is now a pencil icon next to the Avatar
  3. Tap the pencil icon and verify a menu appears
  4. Test adding an avatar and removing an avatar
  5. Create a new workspace
  6. Navigate to the workspace page via Settings
  7. Verify the pencil icon next to the Avatar is clickable
  8. Tap and update the avatar
  9. Verify the image updates
  10. Tap the pencial again and remove the avatar
  11. Verify the default avatar shows again

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-07-08_09-22-02
2021-07-08_09-23-17
2021-07-08_09-24-37
2021-07-08_09-24-48

Mobile Web

2021-07-08_09-41-41
2021-07-08_09-41-54
2021-07-08_09-41-54
2021-07-08_09-41-57
2021-07-08_09-42-13

Desktop

2021-07-08_09-56-27
2021-07-08_09-56-35
2021-07-08_09-57-49

iOS

2021-07-08_09-33-57
2021-07-08_09-34-01
2021-07-08_09-34-06
2021-07-08_09-40-22

Android

2021-07-08_10-24-36
2021-07-08_10-24-41
2021-07-08_10-24-50
2021-07-08_10-24-56

@marcaaron marcaaron self-assigned this Jul 8, 2021
@marcaaron marcaaron changed the title [WIP] Add Workspace Policy Avatars Add Workspace Policy Avatars Jul 8, 2021
@marcaaron marcaaron marked this pull request as ready for review July 8, 2021 20:20
@marcaaron marcaaron requested a review from a team as a code owner July 8, 2021 20:20
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team July 8, 2021 20:20
luacmartins
luacmartins approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and tests well! Great work @marcaaron!

@luacmartins luacmartins merged commit c22f7a9 into main Jul 8, 2021
@luacmartins luacmartins deleted the marcaaron-policyAvatar branch July 8, 2021 21:27
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 9, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @luacmartins