Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile details to avatar and names #3912

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Jul 7, 2021

Fixed Issues

$ #3784

Tests

  1. Open a chat
  2. Click a user's avatar and verify that the detail page opens
  3. Repeat step 2 for a user's name

QA Steps

Same as above,

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mobile-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Jul 7, 2021
@luacmartins luacmartins marked this pull request as ready for review July 8, 2021 18:31
@luacmartins luacmartins requested a review from a team as a code owner July 8, 2021 18:31
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team July 8, 2021 18:31
TomatoToaster
TomatoToaster previously approved these changes Jul 8, 2021
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one suggestion, but it is very much NAB. Since it's not necessary, if you don't want to do that part, feel free to merge this!

src/pages/home/report/ReportActionItemSingle.js Outdated Show resolved Hide resolved
@luacmartins
Copy link
Contributor Author

Updated!

@TomatoToaster TomatoToaster merged commit 710e68a into main Jul 9, 2021
@TomatoToaster TomatoToaster deleted the cmartins-user-profile branch July 9, 2021 14:42
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants