Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile - Make user icon and name clickable anywhere in the app #3784

Closed
isagoico opened this issue Jun 28, 2021 · 6 comments
Closed

User Profile - Make user icon and name clickable anywhere in the app #3784

isagoico opened this issue Jun 28, 2021 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Jun 28, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash
  2. Try clicking on another's user's icon or name around the app.

Expected Result:

Clicking on the user icon or name should always open the user's profile/

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App✔️
Mobile Web✔️

Version Number: 1.0.74-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @muttmuure https://expensify.slack.com/archives/C01GTK53T8Q/p1624891338163400

Anyone else think we should bring up a user’s profile by clicking on their icon or name anywhere in app?

@MelvinBot
Copy link

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cead22 cead22 removed their assignment Jun 28, 2021
@muttmuure

This comment has been minimized.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 30, 2021

If you mark it as external, I can take this task. Just need to wrap the elements around Pressable and navigate to the participant.

@shawnborton
Copy link
Contributor

Can we also make the names in the chat/group header bring up the profile?

This should just bring up the group info as a sideDocked modal, and then from here you should be able to click on individual names.

@muttmuure
Copy link
Contributor

This should just bring up the group info as a sideDocked modal, and then from here you should be able to click on individual names.

Thanks good call out

@luacmartins luacmartins self-assigned this Jul 7, 2021
@luacmartins luacmartins added Improvement Item broken or needs improvement. Reviewing Has a PR in review labels Jul 8, 2021
@luacmartins
Copy link
Contributor

PR #3912 deployed to production. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants