Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show local time for User in 1:1 chat #3883

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 5, 2021

Details

Fixed Issues

$ Fixes #3819

Tests | QA Steps

  1. Open Any conversation on E.cash.
  2. Other user's Local Time should be visible over the composer.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

time-m

iOS

Android

time-a

@parasharrajat parasharrajat marked this pull request as ready for review July 6, 2021 21:41
@parasharrajat parasharrajat requested a review from a team as a code owner July 6, 2021 21:41
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team July 6, 2021 21:41
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the app crashing when I log out / log in, here's some screenshots:

Screen Shot 2021-07-07 at 7 12 07 AM
Screen Shot 2021-07-07 at 7 12 59 AM

@parasharrajat
Copy link
Member Author

Oh Damn. Let me check. thanks for testing it.

@parasharrajat
Copy link
Member Author

@Beamanator Just fixed. Thanks.

@Beamanator Beamanator self-requested a review July 7, 2021 18:16
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty slick! One more thing I found - when we have the timezone text showing in a report, it looks like ReportActionCompose drops down a bit, and when you're on a report which doesn't show timezone, ReportActionCompose shifts back up a bit. Can we fix this?

Screen.Recording.2021-07-07.at.12.33.30.PM.mov

src/pages/home/report/ParticipantLocalTime.js Outdated Show resolved Hide resolved
@parasharrajat
Copy link
Member Author

@Beamanator Updated. Please test now. I didn't find any jump but I think height is causing that so I have fixed it.

@Beamanator Beamanator self-requested a review July 8, 2021 14:51
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on web, mweb & iOS - looks great! 👍 LGTM

@Beamanator Beamanator merged commit ac0f038 into Expensify:main Jul 8, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

@rdjuric
Copy link
Contributor

rdjuric commented Jul 9, 2021

@parasharrajat @Beamanator, I noticed a small issue with this feature. The name is disappearing if the string is bigger than the flex container. Here's a vid to help

web.mov

@parasharrajat
Copy link
Member Author

parasharrajat commented Jul 9, 2021

Good to know. @rdjuric It just need flex:nowrap. I will patch it up.

@isagoico
Copy link

isagoico commented Jul 9, 2021

@parasharrajat Mmmm I'm still unable to see the new feature on my side, can you guys confirm this is on staging? (I'm checking on build 1.0.76-2)
image

@parasharrajat
Copy link
Member Author

I think its yet to be #3905.

@roryabraham
Copy link
Contributor

Sorry @parasharrajat @isagoico, my above comment was incorrect. It was added to the deploy checklist in error – this is not on staging yet. Going to check it off the deploy checklist for now. We'll want to be careful to make sure it gets tested in the next checklist.

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants