-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Show local time for User in 1:1 chat #3883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh Damn. Let me check. thanks for testing it. |
@Beamanator Just fixed. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks pretty slick! One more thing I found - when we have the timezone text showing in a report, it looks like ReportActionCompose
drops down a bit, and when you're on a report which doesn't show timezone, ReportActionCompose
shifts back up a bit. Can we fix this?
Screen.Recording.2021-07-07.at.12.33.30.PM.mov
@Beamanator Updated. Please test now. I didn't find any jump but I think height is causing that so I have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on web, mweb & iOS - looks great! 👍 LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
@parasharrajat @Beamanator, I noticed a small issue with this feature. The name is disappearing if the string is bigger than the flex container. Here's a vid to help web.mov |
Good to know. @rdjuric It just need |
@parasharrajat Mmmm I'm still unable to see the new feature on my side, can you guys confirm this is on staging? (I'm checking on build 1.0.76-2) |
I think its yet to be #3905. |
Sorry @parasharrajat @isagoico, my above comment was incorrect. It was added to the deploy checklist in error – this is not on staging yet. Going to check it off the deploy checklist for now. We'll want to be careful to make sure it gets tested in the next checklist. |
🚀 Deployed to production in version: 1.0.77-5🚀
|
Details
Fixed Issues
$ Fixes #3819
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
Android