[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money #33990

lanitochka17 · 2024-01-05T00:48:16Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Login with gmail account on ND site
2.Go to any 1:1 DM
Tap + FAB button
Select either Manual, Scan or Distance option
Reload page

Expected Result:

Previous opened chat history should display on reloading page after selecting Request money options

Actual Result:

Hmm... it's not here page displayed on reloading page after selecting Request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6332682_1704414716168.New_video.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01356e28bc3ed07d0f
Upwork Job ID: 1743071894141489152
Last Price Increase: 2024-01-19
Automatic offers:

cubuspl42 | Reviewer | 28120404
DylanDylann | Contributor | 28120405

melvin-bot · 2024-01-05T00:48:20Z

Job added to Upwork: https://www.upwork.com/jobs/~01356e28bc3ed07d0f

melvin-bot · 2024-01-05T00:48:21Z

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2024-01-05T00:48:23Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2024-01-05T00:48:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

unidev727 · 2024-01-05T01:09:14Z

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Chat- Hmm it's not here page displayed on reloading page after selecting Request money.

What is the root cause of that problem?

The root cause is that we use new reportId(doesn't exist) when we create money request and CustomRouter returns random reportId for CENTRAL_PANE_NAVIGATOR here in this case without checking report.

create/request/start/1/8425039469826829/manual | scan | distance
The route has reportId param so the getLastAccessedReportID doesn't work in these 3 routes.

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 31 to 33 in dc3e19b

    
               return topmostRoute.params.reportID; 
        
           }

What changes do you think we should make in order to solve the problem?

We should check if report exists regardless reportId is valid here and if report doesn't exist, we shouldn't return that reportId.

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 30 to 32 in dc3e19b

    
           if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID) { 
        
               return topmostRoute.params.reportID; 
        
           }

to

if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID && ReportUtils.getReport(topmostRoute.params.reportID)?.reportID) {
        return topmostRoute.params.reportID;
}

screen-capture.4.webm

What alternative solutions did you explore?

N/A

tienifr · 2024-01-05T01:21:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm... it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

When creating money request via FAB, we'll generate a random reportID and put in the route. When reloading we're unable to find the report associated with that reportID so this issue happens.

What changes do you think we should make in order to solve the problem?

If we're on the request money/split bill/related route, and we cannot find any report matching reportID in Onyx, in here fallback to the getLastAccessedReportID.

We can optionally optimistically create the report for those reportID as well, with the isOptimisticReport: true field, and when we find the request money/split bill report by the reportID, if what we found is an optimistic report, then fallback to using getLastAccessedReportID. We can then clear this optimistic report when we complete/get out of the money request flow.

What alternative solutions did you explore? (Optional)

NA

yh-0218 · 2024-01-05T05:03:57Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm... it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

When we create money request via FAB, we generate a random reportID and put in the route.
This random reportID make this issue.

What changes do you think we should make in order to solve the problem?

We need to compare route?.params?.reportID and getLastAccessedReportID here

if (route?.params?.reportID === reportID) {

What alternative solutions did you explore? (Optional)

Screen.Recording.2024-01-05.at.7.02.48.AM.mov

DylanDylann · 2024-01-05T09:59:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

When we open the app by the deeplink https://dev.new.expensify.com:8082/create/request/start/1/317873788367143/manual, we add the report to the CENTRAL_PANE_NAVIGATOR by the below function:

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 42 to 43 in 6fad557

    
           const addCentralPaneNavigatorRoute = (state: State) => { 
        
               const reportID = getTopMostReportIDFromRHP(state);

In this case, the getTopMostReportIDFromRHP will return the 317873788367143, it is the random reportID is generated when we create iou request and have null value, that leads to the "Hmm it`s not here page" screen displayed.

What changes do you think we should make in order to solve the problem?

We need to make sure when we open the deeplink https://dev.new.expensify.com:8082/create/request/start/1/317873788367143/manual, app does not add the report screen with reportID = 317873788367143 to CENTRAL_PANE_NAVIGATOR
We can do it by updating getTopMostReportIDFromRHP to:

const getTopMostReportIDFromRHP = (state: State): string => {
    if (!state) {
        return '';
    }
    const topmostRightPane = state.routes.filter((route) => route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR).at(-1);

    if (topmostRightPane?.state) {
        return getTopMostReportIDFromRHP(topmostRightPane.state);
    }
    const topmostRoute = state.routes.at(-1);
+  if (topmostRoute?.params && topmostRoute.params.iouType === "request") {
+        return '';
+    }

    if (topmostRoute?.state) {
        return getTopMostReportIDFromRHP(topmostRoute.state);
    }
    if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID) {
        return topmostRoute.params.reportID;
    }

    return '';
};

What alternative solutions did you explore? (Optional)

NA

melvin-bot · 2024-01-08T17:44:24Z

@cubuspl42, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

adelekennedy · 2024-01-08T18:05:21Z

@cubuspl42 it looks like there are a few proposals to review!

cubuspl42 · 2024-01-09T09:43:55Z

@unicorndev-727

We need to consider above 3 routes so that getLastAccessedReportID works properly.

Consider how? I don't understand your solution, sorry.

@tienifr

fallback to the getLastAccessedReportID.

What's the UX of this solution? Does the "random" report ID stay in the URL bar?

We can optionally optimistically create the report for those reportID as well

This brings garbage collection challenges... Do you think this is a realistic option? Anything goes "wrong" (the user closes a tab, whatever) and we're left with garbage in this solution, right?

@DylanDylann

I think we have a different understanding what a deeplink is. In the context of this Web-specific issue, you probably just mean "URL".

We need to make sure when we open ... app does not add the report screen with reportID = 317873788367143 to CENTRAL_PANE_NAVIGATOR

You stick to the example, but what's the logic of the suggested solution?

I guess that it's something like "when te report ID in the URL points to a non-existing report, we...", but you didn't state this explicitly. Examples are good, but they can't be the only thing describing a solution.

We can update getTopMostReportIDFromRHP to:

You said "can". Is it an optional part of the solution?

Let's focus on the code diff now.

First, a nit. Isn't topmostRoute?.params && topmostRoute.params.iouType equivalent to topmostRoute?.params?.iouType (when converted to a boolean)?

Leaving nits aside... From the proposal itself, I don't think it's clear how the first change (not adding a route with invalid report ID to CENTRAL_PANE_NAVIGATOR) relates to the second (adjusting getTopMostReportIDFromRHP).

unidev727 · 2024-01-09T09:58:45Z

@unicorndev-727

We need to consider above 3 routes so that getLastAccessedReportID works properly.

Consider how? I don't understand your solution, sorry.

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.ts

Line 47 in dc3e19b

if (route?.params?.reportID) {

We need to add a new condition here if report with this reportId exists.

if (route?.params?.reportID && ReportUtils.getReport(route.params.reportID)) {

So if report doesn't exist, we can set lase accessed report id from getLastAccessedReportID.

unidev727 · 2024-01-09T10:14:09Z

@cubuspl42
I updated the proposal and added the result video.

cubuspl42 · 2024-01-09T10:31:58Z

@unicorndev-727

So, what actually happens after the reload in the proposed solution, as I understand it:

In the URL, we present the old random ID of a temporary report (which doesn't exist anymore)
The RHP presents the "Request money" flow associated with a new report with a new random ID

Is this correct?

unidev727 · 2024-01-09T10:33:45Z

Now it is.

cubuspl42 · 2024-01-09T10:35:35Z

This is a bit work-aroundish, if not hacky, to present some "garbage" from the URL, just because it makes the implementation easier.

cubuspl42 · 2024-01-09T10:37:40Z

Everyone,

I do not understand one important high-level thing here. Wy do we include the report ID in the URL, if this is not a persisted entity?

Why... /create/request/start/1/317873788367143/manual
Why not... /create/request/start/1/manual

Also, what is 1?

unidev727 · 2024-01-09T10:40:00Z

That is transactionID.

MONEY_REQUEST_CREATE: {
        route: 'create/:iouType/start/:transactionID/:reportID',
        getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string) => `create/${iouType}/start/${transactionID}/${reportID}` as const,
    },

DylanDylann · 2024-01-09T10:41:10Z

@cubuspl42 I updated proposal based on your comment

cubuspl42 · 2024-01-09T10:52:26Z

@DylanDylann Oh, I misunderstood your proposal structure. The second bullet is the implementation of the idea from the first one. This changes a lot.

Again, nit: Isn't this equivalent to topmostRoute?.params?.iouType === "request"?

Also, what's the UX of this solution? How does the URL behave from user's perspective? Does the "old" random ID stay in the URL bar?

DylanDylann · 2024-01-09T12:07:37Z

@cubuspl42

Isn't this equivalent to topmostRoute?.params?.iouType === "request"?

What is "this" here?

Does the "old" random ID stay in the URL bar?

Yes. Because when user opens /create/request/start/1/317873788367143/manual, the RequestMoney screen is focused, so the reportID 317873788367143 still stays in the URL bar

cubuspl42 · 2024-01-22T10:35:51Z

Still active discussion

adelekennedy · 2024-01-22T16:32:23Z

clearing the overdue - still discussion above

adelekennedy · 2024-01-23T17:22:39Z

Hmm - I'm not sure why the overdue didn't clear. testing.

cubuspl42 · 2024-01-24T08:37:32Z

Let's assign @DylanDylann.

We'll change the app behavior to always present the last visited report in the central pane, regardless of the reportId (the pre-set money request participant) in the URL.

@DylanDylann persistently presented the benefits of his idea and got it approved by the internal engineer.

C+ reviewed 🎀 👀 🎀

melvin-bot · 2024-01-24T08:37:38Z

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-01-24T22:18:38Z

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-01-24T22:18:42Z

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

DylanDylann · 2024-01-26T00:44:25Z

@cubuspl42 PR #35210 is ready to review

melvin-bot · 2024-01-31T02:28:54Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-01-31T02:28:57Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix/33990: Not here page appear when refreshing #35210

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

@cubuspl42 requires payment automatic offer (Reviewer)
@DylanDylann requires payment automatic offer (Contributor)

melvin-bot · 2024-01-31T02:28:58Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@cubuspl42 / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42 / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42 / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42 / @DylanDylann] Determine if we should create a regression test for this bug.
[@cubuspl42 / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

cubuspl42 · 2024-02-07T10:32:39Z

The PR that introduced the bug has been identified. Link to the PR:
- The old expected behavior appeared buggy from the user's perspective. There was a long discussion in which we concluded that it's best to define a new expected behavior.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- No need for additional discussion
Determine if we should create a regression test for this bug.
- No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- N/A

cubuspl42 · 2024-02-08T08:56:48Z

@adelekennedy Were the payments processed?

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 5, 2024

melvin-bot bot changed the title ~~Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money~~ [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money Jan 5, 2024

melvin-bot bot assigned adelekennedy Jan 5, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 5, 2024

melvin-bot bot assigned cubuspl42 Jan 5, 2024

melvin-bot bot added the Overdue label Jan 8, 2024

melvin-bot bot removed the Overdue label Jan 8, 2024

melvin-bot bot added the Overdue label Jan 22, 2024

melvin-bot bot removed the Overdue label Jan 23, 2024

melvin-bot bot assigned francoisl Jan 24, 2024

francoisl assigned DylanDylann Jan 24, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2024

DylanDylann mentioned this issue Jan 25, 2024

Fix/33990: Not here page appear when refreshing #35210

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 25, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024

melvin-bot bot changed the title ~~[$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money~~ [HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money Jan 31, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2024

adelekennedy closed this as completed Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money #33990

[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money #33990

lanitochka17 commented Jan 5, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

unidev727 commented Jan 5, 2024 •

edited

Loading

tienifr commented Jan 5, 2024 •

edited

Loading

yh-0218 commented Jan 5, 2024

DylanDylann commented Jan 5, 2024 •

edited

Loading

melvin-bot bot commented Jan 8, 2024

adelekennedy commented Jan 8, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024 •

edited

Loading

unidev727 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024

DylanDylann commented Jan 9, 2024 •

edited

Loading

cubuspl42 commented Jan 9, 2024 •

edited

Loading

DylanDylann commented Jan 9, 2024

cubuspl42 commented Jan 22, 2024

adelekennedy commented Jan 22, 2024

adelekennedy commented Jan 23, 2024

cubuspl42 commented Jan 24, 2024 •

edited

Loading

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

DylanDylann commented Jan 26, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

cubuspl42 commented Feb 7, 2024

cubuspl42 commented Feb 8, 2024

[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money #33990

[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money #33990

Comments

lanitochka17 commented Jan 5, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Jan 5, 2024

unidev727 commented Jan 5, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

tienifr commented Jan 5, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

yh-0218 commented Jan 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented Jan 5, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jan 8, 2024

adelekennedy commented Jan 8, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024 • edited Loading

unidev727 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

cubuspl42 commented Jan 9, 2024

unidev727 commented Jan 9, 2024

DylanDylann commented Jan 9, 2024 • edited Loading

cubuspl42 commented Jan 9, 2024 • edited Loading

DylanDylann commented Jan 9, 2024

cubuspl42 commented Jan 22, 2024

adelekennedy commented Jan 22, 2024

adelekennedy commented Jan 23, 2024

cubuspl42 commented Jan 24, 2024 • edited Loading

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

DylanDylann commented Jan 26, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

cubuspl42 commented Feb 7, 2024

cubuspl42 commented Feb 8, 2024

lanitochka17 commented Jan 5, 2024 •

edited by melvin-bot bot

Loading

unidev727 commented Jan 5, 2024 •

edited

Loading

tienifr commented Jan 5, 2024 •

edited

Loading

DylanDylann commented Jan 5, 2024 •

edited

Loading

unidev727 commented Jan 9, 2024 •

edited

Loading

DylanDylann commented Jan 9, 2024 •

edited

Loading

cubuspl42 commented Jan 9, 2024 •

edited

Loading

cubuspl42 commented Jan 24, 2024 •

edited

Loading