[HOLD for payment 2024-04-05] [$500] Android - Chat - Chat flickers if a PDF was previously sent or when a new one is sent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Tap on ''+'' button
4. Select "Add attachment''
5. Upload a PDF file
6. Check the chat view

Expected Result:

Chat view should not flicker when there are previously sent PDF files or when a PDF file is sent in the chat

Actual Result:

Chat view flickers when there are previously sent PDF file, or when user send a PDF file

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343207_1705338283475.Specifc_PDF_-Android_build.mp4

Slack___TEST_ing__3-2023-12-28_22_42_24.367-2024-01-15 16_09_19.026.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184552ac59563af4b
• Upwork Job ID: 1746946018928300032
• Last Price Increase: 2024-03-19
• Automatic offers:
• jsdev2547 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0184552ac59563af4b

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Ykumar1415]

I Tried to produce the issue and followed below actions :
Open the app
Navigate to any chat
Tap on ''+'' button
Select "Add attachment''
Upload a PDF file
Check the chat view

got same response.

[melvin-bot]

📣 @Ykumar1415! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[trjExpensify]

@sobitneupane do you have a native Android device by any chance?

[sobitneupane]

Nope. I don't have Android device with me.

[melvin-bot]

@trjExpensify, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Awaiting proposal review, Melvin!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sobitneupane]

@trjExpensify I will be able review the issue only in the weekend. Please feel free to re-assign the issue if it's high-priority or urgent.

[trjExpensify]

This weekend is cool!

[melvin-bot]

@trjExpensify @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@trjExpensify, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

👋 How'd you get on @sobitneupane over the weekend?

[sobitneupane]

Oops I could not get to it before weekend. I will review it by EOD tomorrow NPT.

[trjExpensify]

Thanks!

[sobitneupane]

@Sourcecodedeveloper

I believe the flicker that we are talking about is constant flickering of the pdf thumbnail. Not the change from placeholder thumbnail.

Screen.Recording.2024-02-01.at.18.44.46.mov

The root cause of the issue is the image size is defaulting to width 200 and height 200 after upload and then GetSize() is called after upload which then calculates correct width and height and the image size is adjusted which causes the flicker.

[melvin-bot]

📣 @jsdev2547 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ghost]

@sobitneupane Thanks for the review. I have PR(#38766) ready for review.

[srikarparsi]

Hi @sobitneupane and @jsdev2547, QA reported that they are still able to reproduce the issue. Can you please take a look into it when you get a chance.

[ghost]

@sobitneupane I have tested on main and not getting any flickers.

android.webm

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• resolve flicker #38766

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @jsdev2547 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time, @sobitneupane!

[sobitneupane]

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#18485

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#18485 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is an edge case and can only be reproduced with some odd sized images.

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#34520 (comment)

[sobitneupane]

Regression Test Proposal:

1. Go to any chat and upload pdf/image with width much larger than height.
2. Verify the pdf thumbnail/image does not flicker in Android/native.

Do we agree 👍 or 👎

[trjExpensify]

Thanks! As it's quite the edge case, I'm down to not a regression test for it.

Payment summary as follows:

• $500 to @sobitneupane for the C+ review (go ahead and submit)
• $500 to @jsdev2547 for the fix. - paid

@jsdev2547 an offer wasn't sent, so can you confirm your Upwork handle?

[ghost]

@trjExpensify Please check, I did receive offer (#34520 (comment))

[trjExpensify]

ah, it expired and closed. Sent you a new one!

[ghost]

@trjExpensify I accepted the offer, need to process payment.

[trjExpensify]

Yeah, that's typically the next step. 😆 Paid!

[JmillsExpensify]

$500 approved for @sobitneupane