[HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js

[tgolen]

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestConfirmPage
New Component IOURequestStepConfirmation

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

1. Look at the history of the Old Component
2. If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
3. Replace all uses of the Old Component with the New Component
4. Remove all traces of Old Component
5. Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
6. Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d384157eb0d34e8a
• Upwork Job ID: 1747632941224689664
• Last Price Increase: 2024-01-17
• Automatic offers:
• DylanDylann | Contributor | 28109099

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lancer-spaid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js

What is the root cause of that problem?

Cleaning of MoneyRequestConfirmPage

What changes do you think we should make in order

The component here will be deleted.



Remove this line from ModalStackNavigation.js:



App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 96 in a7a3e7f

[SCREENS.MONEY_REQUEST.CONFIRMATION]: () => require('../../../pages/iou/steps/MoneyRequestConfirmPage').default as React.ComponentType,



History page here has a few changes. Most of these are with the violations feature. We will take a look at the specific logic changes and add the changes to IOURequestStepConfirmation

[njmulsqb]

I would love to take this!

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js

What is the root cause of that problem?

Remove deprecated component

What changes do you think we should make in order to solve the problem?

1. Remove MoneyRequestConfirmPage component and all traces like

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 96 in 278d04e

[SCREENS.MONEY_REQUEST.CONFIRMATION]: () => require('../../../pages/iou/steps/MoneyRequestConfirmPage').default as React.ComponentType,

App/src/libs/Navigation/linkingConfig.ts

Line 429 in 278d04e

[SCREENS.MONEY_REQUEST.CONFIRMATION]: ROUTES.MONEY_REQUEST_CONFIRMATION.route,

App/src/ROUTES.ts

Lines 261 to 264 in a2f5bd5

	MONEY_REQUEST_CONFIRMATION: {
	route: ':iouType/new/confirmation/:reportID?',
	getRoute: (iouType: string, reportID = '') => `${iouType}/new/confirmation/${reportID}` as const,
	},

App/src/SCREENS.ts

Line 141 in a2f5bd5

CONFIRMATION: 'Money_Request_Confirmation',

App/src/libs/Navigation/types.ts

Lines 188 to 191 in a2f5bd5

	[SCREENS.MONEY_REQUEST.CONFIRMATION]: {
	iouType: string;
	reportID: string;
	};

2. For new component IOURequestStepConfirmation

In here

App/src/ROUTES.ts

Lines 308 to 311 in a2f5bd5

	MONEY_REQUEST_STEP_CONFIRMATION: {
	route: 'create/:iouType/confirmation/:transactionID/:reportID',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string) => `create/${iouType}/confirmation/${transactionID}/${reportID}` as const,
	},

We need to use the new :action param (instead of being hard-coded with "create") like we did here

App/src/ROUTES.ts

Lines 362 to 366 in a2f5bd5

	MONEY_REQUEST_STEP_SCAN: {
	route: ':action/:iouType/scan/:transactionID/:reportID',
	getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo),
	},

3. Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/IOURequestStepConfirmation.js

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d384157eb0d34e8a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[ghost]

Dibs

[dukenv0307]

I'd love to work on this issue.

[melvin-bot]

Upwork job price has been updated to $250

[parasharrajat]

Looks like @DylanDylann has a more complete proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

Agreed!

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[adelekennedy]

waiting on PR

[DylanDylann]

I am working on PR

[parasharrajat]

Oh Hold.

[parasharrajat]

Still on Hold.

[parasharrajat]

@DylanDylann any updates?

[DylanDylann]

Waiting for this PR

[melvin-bot]

@NikkiWines, @parasharrajat, @adelekennedy, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

@DylanDylann let's go, #34613 is merged.

[DylanDylann]

@adelekennedy Please remove the hold label

[parasharrajat]

@adelekennedy This issue is no more on Hold. In fact, the PR for this is merged. Please fix the title.

[adelekennedy]

thank you @parasharrajat!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove MoneyRequestConfirmPage #35461

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @DylanDylann requires payment automatic offer (Contributor)

[parasharrajat]

This is not a bug but a code refactor. Bug-zero checklist does not apply. cc: @adelekennedy

[adelekennedy]

No checklist - payment is due on 4/15

[adelekennedy]

Payouts due:

• Contributor: $250 @DylanDylann (Upwork)
• Contributor+: $250 @parasharrajat (NewDot)

[parasharrajat]

Payment requested as per #34615 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat