-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Web - Infinite loader appears when navigate to restricted links #34800
Comments
Job added to Upwork: https://www.upwork.com/jobs/~013c4e3dfa7c42f2b3 |
Triggered auto assignment to @trjExpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Infinite loader appears when navigate to restricted links What is the root cause of that problem?The pages use What changes do you think we should make in order to solve the problem?We should change this condition to navigate to where we want it instead of displaying
And for mobile we can just navigate to home screen
Addition: If we still need to display
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
+ if (shouldShowNotFoundPage) {
return null;
}
What alternative solutions did you explore? (Optional)
|
@trjExpensify Can you confirm the expected behavior in this issue. Is this "User should be redirected to a blank conversation with a message indicating that the user doesn't have access in web and to LHN in mobile view" ? |
Thanks for investigating this! We definitely need to update the issue (or even close it) based on these findings |
Does that mean someone will see two "NotFound" errors? |
@trjExpensify Yes. It is the current behavior |
@trjExpensify FYI, In staging: |
Got it, thanks! So we've come across the "double Hmm..." in the workspace settings in the new ideal nav we're working on, and opted for a full page error on desktop instead (ref). @shawnborton @dannymcclain @dubielzyk-expensify I wonder if we want to do the same here? It's slightly different insofar as the main pane (chat) and If we're okay with leaving this as is, then I agree we can close out this issue as the infinite spinners as reported are resolved. |
@trjExpensify @cubuspl42 I think there is not important the |
Ah wait.. these are links are for any given room's details, members and settings pages in the LHN.
If we do what you're suggesting, when you click one of these links won't we end up:
Equally, how do we handle if someone has access to the chat in question, but not a particular page in its settings? The main pane chat shouldn't result in NotFound, only the applicable RHP setting page, right? Overall, I think we probably leave this as it is. Though @lanitochka17, perhaps you can shed some light on where this bug report came from in the test suite. |
|
Right, so I'm questioning if it's really worth adding that code as a condition here? We've established we independently need a NotFound page on the main chat page, and the RHP for when you have access to the room but not certain settings pages. So given that we have this dynamic, and it's not a case where it warrants a full page NotFound error like the ref here, I'm inclined to do nothing. Happy for a second opinion from the design team tagged though! |
Down to follow Tom's suggestion :) |
Alrighty, closing it out! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
https://staging.new.expensify.com/r/6821704960193694/details
https://staging.new.expensify.com/r/6821704960193694/participants
https://staging.new.expensify.com/r/6821704960193694/settings
Expected Result:
User should be redirected to a blank conversation with a message indicating that the user doesn't have access in web and to LHN in mobile view
Actual Result:
"Hmm it is not here..." page appear but there is Infinite loader on RHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6347438_1705651403600.Recording__1857.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: