-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-14] [$500] Web - Settings - The same text is also displayed as tooltips #34961
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01938e9b3ecfb536b8 |
Triggered auto assignment to @sonialiap ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Priority mode selector shows tooltips with the same text as alternameText. What is the root cause of that problem?We do not disable tooltips for the What changes do you think we should make in order to solve the problem?We should set <SelectionList
sections={[{data: priorityModes}]}
onSelectRow={updateMode}
shouldShowTooltips={false}
initiallyFocusedOptionKey={_.find(priorityModes, (mode) => mode.isSelected).keyForList}
/> App/src/pages/settings/Preferences/PriorityModePage.js Lines 59 to 63 in addfa88
We should do the same in other places where we do not need the tooltips:
There are many such potential places, need to go through them when implementing the PR. What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.It shouldn't show any tooltips in What is the root cause of that problem?We do not disable tooltips in some settings configuration pages like:
What changes do you think we should make in order to solve the problem?I think for the setting configuration page, we should use What alternative solutions did you explore? (Optional) |
Proposal Please re-state the problem that we are trying to solve in this issue. What is the root cause of that problem? What changes do you think we should make in order to solve the problem?
Writing this piece of code |
@paultsimura Please add the message if you edit proposal |
📣 @adisher! 📣
|
ProposalUpdated proposal to add a more complete list of places where the same change should be made. But the solution remains the same. |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Update proposal to explain the list we should not show the tooltip |
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?We do not pass What changes do you think we should make in order to solve the problem?We generally don't need tooltips for most of the components that uses Result |
Contributor details Proposal!The problem is in this file. const renderItem = ({item, index, section}) => {
So showToolTip is based on indexOffset of the section. The section data is in PriorityModePage So you should configure to Thanks for consideration. |
📣 @edge-of-cliff! 📣
|
Contributor details |
|
Contributor details |
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.The same text is also displayed as tooltips. What is the root cause of that problem?We're having the tooltips set for What changes do you think we should make in order to solve the problem?The reason we need a tooltip in the first place is so that if the title or subtitle of the SelectionList item are longer than the container width and showing ellipsis, we want the user to be able to view the full content of the title/subtitle. We did that by making the And also, Tooltips are expensive, rendering a lot of them can degrade performance. So we should only show Tooltips when necessary, that means when the "ellipsis" effect occurs. We can create a custom And then we use that component for the SelectionListItem, and now we never have to think which page should have tooltips, which page should not any more. Any text that has ellipsis will have the tooltips to let users view full content. Of course for platforms other than web (that doesn't have Tooltips), we can just return What alternative solutions did you explore? (Optional)In addition to the main solution, if for any page we want to disable/enable Tooltips always, whether there is ellipsis or not (which I think we should not do because texts/translations can change any time), we can control that by a prop (like |
ProposalPlease re-state the problem that we are trying to solve in this issue.The same text is also displayed as tooltips What is the root cause of that problem?In
What changes do you think we should make in order to solve the problem?I think we shouldn't show the tooltip by default unless it's defined, also it's not quite useful to have the same text with content. I'd recommend adding In
What alternative solutions did you explore? (Optional) |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Continuing the discussion in #35460 (comment) |
@eVoloshchak is #35460 (comment) a regression? |
melvin, I just commented on this issue, not overdue |
@eVoloshchak bumping my question above #34961 (comment) |
@sonialiap, I cannot reproduce this, works fine for me on both Chrome and Safari Screen.Recording.2024-02-20.at.16.00.06.mov |
Sounds good, making payments @eVoloshchak $500 please request in ND and complete the checklist |
Regression Test Proposal
Do we agree 👍 or 👎 |
$500 approved for @eVoloshchak based on summary above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.29.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #34702
Action Performed:
Expected Result:
It shouldn't show any tooltips.
Actual Result:
The same text is also displayed as tooltips.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6351741_1706005634650.bandicam_2024-01-19_13-12-11-895.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: