[HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Workspace - Workspace section loads infinitely after returning from Connect bank account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• Workspace default currency is not USD

1. Go to workspace settings
2. Go to Cards
3. Click Connect bank account
4. Click back button

Expected Result:

Page loads without issue

Actual Result:

Page loads infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353420_1706113368394.20240124_201203__1_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cristipaval]

It seems to be a regression of this PR cc @parasharrajat @aldo-expensify

[cristipaval]

Opened a PR with a fix

[parasharrajat]

Oops. Didn't notice that. Thanks @cristipaval . But I see that shouldShowLoading was already true before that PR. 🤔 Got it now.

[cristipaval]

Oops. Didn't notice that. Thanks @cristipaval . But I see that shouldShowLoading was already true before that PR. 🤔 Got it now.

Thanks @parasharrajat, for teaching me some Typescript to get the PR quickly ready for merge 🙇

[aldo-expensify]

Merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

If no regressions arise, payment will be issued on 2024-02-01. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

If no regressions arise, payment will be issued on 2024-02-05. 🎊

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[cristipaval]

@JmillsExpensify I added the Bug label to have a BZ member.

This is a regression. I fixed it and @parasharrajat reviewed it. He's also the C+ for the PR that introduced the regression. I don't know if any payment is due in this case 👀

[cristipaval]

Asked internally here about the above

[parasharrajat]

Yes, no payment is required. We are good to close it.

[cristipaval]

Thanks @parasharrajat! Thanks again for quickly jumping into helping me fix it 🙇