Deploy Checklist: New Expensify 2024-01-24

[github-actions]

Release Version: 1.4.31-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• The app should take the user back to the profile page when the user clicks the back button in the web browser #28999
• Fix: Attachment modal is not closed when click notification #30968
• Add full screen engagement modal to NewDot #32154
• Handle API errors to trigger force upgrades of the app  #32326
• [TS migration] Migrate 'LHNOptionsList' component to TypeScript #33108
• Hide pay button when auto reimbursement enabled #33987
• Append country code for search phone number in workspace invite and room invite #34009
• fix: re-add notification preference condition to unread reports calculations #34025
• Add updateMoneyRequestCategory command #34073
• Display merchant in report name of transaction report if exist #34216
• Fix - include current user in group chat members list #34237
• Fix invited members for admin threads #34362
• [TS migration] Migrate 'WorkspacePageWithSections' page to TypeScript #34391
• Adds Receipt Component to Money Request confirmation page #34533
• fix: In offline, tapping 3 dots on top and selecting "Join", user unable to join the thread #34550
• Fallback report action created if reportActions is empty #34551
• fix: Return a generic receipt for pending distance requests #34604
• fix Time input for custom time is not auto focused #34712
• [NoQA] Update the Readme file for performance tests #34714
• change event listener in popover provider #34788
• Paint the status bar of the Referral page #34806
• feat: disable enforced report fields #34884
• [NoQA] Skip flaky reassure test #34972
• fix android picker text color in light theme #35032
• [CP Staging] Fix reggression after LHNOptionsList TS migration #35044
• [CP Staging] Revert "Handle API errors to trigger force upgrades of the app " #35046
• Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098
• [CP Staging] Revert "Merge pull request #34237 from FitseTLT/fix-include-current-u… #35099
• Use report.reportID when updating notification preferences #35109

Internal QA:

• [TS Migration] Adjustments on KYCWall #34870 - @ruben-rebelo

Deploy Blockers:

• [$500] Android - App crashes when upload a new build 1.4.31-1 #35066
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] LHN - The employee's LHN account is displayed instead of the room name #35068
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Workspace - Workspace section loads infinitely after returning from Connect bank account #35071
• [$500] Room - Member avatar tooltip shows "Hidden" in room member list #35073
• Workspace room titles are broken in LHN #35074
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Group chat - Group chat shows only creator avatar in LHN and creator in member list #35075
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Notifications - Unable to save notification preference #35076
• [$500] Bank Account - Arrow next to bank account selector is not clickable #35083
• [$500] Room - @expensify.sms suffix appears after invitation & disappears after opening user avatar #35089
• [HOLD for payment 2024-02-07] [$500] Thread - Thread header in room shows skeleton loading when replying in thread offline #35090
• [HOLD for payment 2024-02-07] Bank account - Wrong account number error is still shown after restarting the add BA process #35095
• Offline indicator is missing on Welcome to Expensify page #35110
• Chat - Phone number is invited to Workspace countless time after invitation to workspace room #35111
• [$500] BA - Bad performance of app after changing the company website to URL that ends with a dot #35124
• [HOLD for payment 2024-03-18] [$500] Public room - Sign-in modal is hidden behind welcome modal after selecting an option #35131

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.31-1 🚀

[Julesssss]

Just noting that a new Android regression is pretty widespread, it wasn't introduced in this version but we should fix and release it ASAP.

[cristipaval]

Checking off #35071, CP request for the fix here

[cristipaval]

Checking off #35076, CP requested here

[mvtglobally]

Regression is at 7% left

PR #34237 is failing #35075
PR #34391 is failing #35071

[thienlnam]

Went through and cleared the blockers! Now waiting on completed regression testing

[thienlnam]

Everything else looks good - blockers were fixed!

[thienlnam]

Only fresh crash affecting a single user

ViewManagersPropertyCache$StringPropSetter.getValueOrDefault

Since this has only happened on old versions and for a single user - it seems fine to progress without it

[thienlnam]

Ah crap, new blocker was added #35131

[thienlnam]