[HOLD for payment 2024-02-07] [$500] Thread - Thread header in room shows skeleton loading when replying in thread offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go offline
2. Go to a room like #admin room
3. Send a message
4. Right click on the message > Reply in thread
5. Repeat Step 1 to 4 with workspace chat

Expected Result:

The thread header will not show skeleton loading

Actual Result:

The thread header shows skeleton loading in room thread, but it displays fine in workspace chat thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353545_1706120378431.20240125_012915.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bbe476f1c4e71160
• Upwork Job ID: 1750326687010930688
• Last Price Increase: 2024-01-25
• Automatic offers:
• situchan | Contributor | 28120619
• s-alves10 | Contributor | 28120622

[melvin-bot]

Triggered auto assignment to @joelbettner (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @Quintar

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread header in room shows skeleton when replying in thread offline

What is the root cause of that problem?

This issue looks like a regression of this PR #34362
We get report name for policy rooms by getAdminRoomInvitedParticipants function

App/src/libs/ReportUtils.ts

Lines 2467 to 2469 in 30aa432

	if (isAdminRoom(report) || isUserCreatedPolicyRoom(report)) {
	return getAdminRoomInvitedParticipants(parentReportAction, parentReportActionMessage);
	}

In this function, we return empty if parentReportAction.originalMessage is empty

App/src/libs/ReportUtils.ts

Lines 2420 to 2422 in 30aa432

	if (!parentReportAction?.originalMessage) {
	return '';
	}

Noting that this value is empty in offline, we get empty string though parentReportActionMessage is not empty

This makes the value of isLoading true

App/src/pages/home/HeaderView.js

Line 220 in 30aa432

const isLoading = !props.report || !title;

This is the root cause

What changes do you think we should make in order to solve the problem?

When original message is empty, we should return parentReportActionMessage

This works as expected

What alternative solutions did you explore? (Optional)

[situchan]

Agree with @s-alves10
I prefer fallback to

App/src/libs/ReportUtils.ts

Line 2470 in 30aa432

return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

In case parentReportActionMessage is also empty, keep [Deleted message] which is production behavior.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bbe476f1c4e71160

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[s-alves10]

@situchan
PR is ready for review #35128

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show parent action message or deleted message #35128

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[JmillsExpensify]

@situchan I'm not seeing a BZ checklist for this issue. Should we have one? I'm particularly interested in your perspective on the need for a regression test.

[situchan]

This was deploy blocker. QA team caught this during staging regression testing.
So no need another regression test.

[JmillsExpensify]

Ok cool! Thanks, I'll handle payments now.

[JmillsExpensify]

Everyone paid out via automatic offers. Closing this issue!