Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Handle API errors to trigger force upgrades of the app " #35046

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[CP Staging] Revert "Handle API errors to trigger force upgrades of the app " #35046

merged 1 commit into from
Jan 24, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Jan 24, 2024 •
edited
Loading

Reverts #32326

Straight revert

fixes #35066

@mountiny mountiny self-assigned this Jan 24, 2024
@mountiny mountiny requested a review from a team as a code owner January 24, 2024 10:43
@melvin-bot melvin-bot bot removed the request for review from a team January 24, 2024 10:44
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 24, 2024

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan situchan mentioned this pull request Jan 24, 2024
Closed
@mountiny
Copy link
Contributor Author

@situchan confirmed this fixes the android crash. #35049

I have been having hard time to build android, moving along as this is unblocking dev enviroments for everyone

@mountiny mountiny merged commit e6f5254 into main Jan 24, 2024
13 of 16 checks passed
@mountiny mountiny deleted the revert-32326-marcaaron-forceAppUpgrade branch January 24, 2024 12:09
@melvin-bot melvin-bot bot added the Emergency label Jan 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 24, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor Author

Straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@wildan-m wildan-m mentioned this pull request Jan 24, 2024
Closed
50 tasks
@mountiny mountiny changed the title Revert "Handle API errors to trigger force upgrades of the app " [CP Staging] Revert "Handle API errors to trigger force upgrades of the app " Jan 24, 2024
OSBotify pushed a commit that referenced this pull request Jan 24, 2024
@mountiny @OSBotify
Merge pull request #35046 from Expensify/revert-32326-marcaaron-force…
a7679e3 
…AppUpgrade

Revert "Handle API errors to trigger force upgrades of the app "

(cherry picked from commit e6f5254)
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Closed
48 tasks
@marcaaron marcaaron mentioned this pull request Jan 24, 2024
Merged
50 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.31-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@aimane-chnaif aimane-chnaif mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@youssef-lr youssef-lr youssef-lr approved these changes

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[$500] Android - App crashes when upload a new build 1.4.31-1
4 participants
@mountiny @OSBotify @Beamanator @youssef-lr