-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle API errors to trigger force upgrades of the app #35114
Handle API errors to trigger force upgrades of the app #35114
Conversation
…des of the app ""
Reviewer Checklist
Screenshots/VideosiOS: NativeupdateiOS.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marcaaron Typescript types are failing, can you take a look to see what happened? Maybe try merging with main |
Yes, thank you! I believe I need to merge main as something broke them across the repo. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.33-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
Copypasta'd from other PR.
This should fix the Android dependency cycle issues hopefully 🙏
Details
Adds an update required view and allows for deprecating older App versions.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/340997
Tests
Setup:
Apply this diff so that the upgrade works. It will be disabled on dev and stagingRealized that if we do not have this on dev or staging people on older app versions could end up very confused so removing it.
Request::MINIMUM_APP_VERSION
variable here so that it is higher than the current app version.Request::MINIMUM_APP_VERSION
Request::MINIMUM_APP_VERSION
variable here so that it is higher than the current app versionTest "Update" button behavior
Web/mWeb - App should refresh page
Android - App should go to the Play Store
iOS - App should go to the App Store
Desktop - App should download dmg file
Offline tests
N/A
QA Steps
QA is not possible for these changes.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Note - I tested on all platforms. However, there were some changes to the body copy so the screenshots do not 100% reflect where we landed.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop