[$500] LHN - Announce room on invited workspace member is not bold

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. User A create workspace
2. User A navigates to announce room> settings> set welcome message
3. User A goes to Settings> Workspace> Members> Invite User B
4. Login as User B

Expected Result:

Announce room on invited workspace member should be bold on LHN

Actual Result:

Announce room of invited workspace member is not bold on LHN, even green line on welcome message appears
Also, welcome message does not change on employee side when admin change the content of welcome message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354010_1706142902654.Recording__1915.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016aee40f12650c4a6
• Upwork Job ID: 1750329685857648640
• Last Price Increase: 2024-02-15
• Automatic offers:
• situchan | Contributor | 28129326

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016aee40f12650c4a6

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New workspaces for the user - does not show up as unread workspaces in LHN. They do get a notification.

What is the root cause of that problem?

We currently create new reports with the same timestamp for lastRead and lastVisibleActionCreated

We only show something as unread if the last read time is before the last visible is created here:

App/src/libs/ReportUtils.ts

Line 3517 in 0d0b0a8

return lastReadTime < lastVisibleActionCreated;

And the announced message, is merely metadata on the report. Not an actual message.

What changes do you think we should make in order to solve the problem?

We should actually show all new channels as unread - this improves the customer experience by showing there's something new. Even if there are no messages in that channel.

We can make a small change here

App/src/libs/ReportUtils.ts

Line 3517 in 0d0b0a8

return lastReadTime < lastVisibleActionCreated;

to also be unread if the lastRead equals lastVisibleActionCreated, indicating the newly created report condition.

Once a user actually clicks on the report - it will be marked as read as the lastRead timestamp updates:

Sample experience with new code:
https://github.com/Expensify/App/assets/157416545/b615bf89-7f34-4fe6-86fa-3579a5638c0f

This also covers the announce use case in this issue.

What alternative solutions did you explore? (Optional)

[dragnoir]

I think it should be fixed here #31748

[Santhosh-Sellavel]

I think it should be fixed here #31748

@dragnoir Can you elaborate on why?
Is that regression from #31748?

[dragnoir]

@Santhosh-Sellavel check this #33881
it's the same issue here and the same problem. The suggested solution is the same in boath #33881 and #31748 but the issue is always there. The solution is not complete and need to handle all the UNREAD cases.

PR update: https://github.com/Expensify/App/pull/34551/files
Second issue proposal: #33881 (comment)

c+ note from the same issue #33881 (comment) and #33881 (comment)

but the PR submitted there #34551 is not tested well.

[Santhosh-Sellavel]

Waiting for feedback #31748 (comment)

I'm unavailable next week, Please assign a new C+ Issue here if required while I am away, thanks!

#31748 (comment)

cc: @lschurr

[lschurr]

Asking for a volunteer in Slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1706555426712459

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[lschurr]

Assigning to @situchan - could you review?

[situchan]

Seems like 2 bugs stated in OP. Checking reproducibility first

[situchan]

Announce room of invited workspace member is not bold on LHN, even green line on welcome message appears

reproduced

---

Also, welcome message does not change on employee side when admin change the content of welcome message

not reproduced

[situchan]

@jeremy-croff can you please explain the root cause in detail?

This has 2 bugs: (might have the same root cause though)

• why LHN text is not bolded when login first time after getting invited?
• why unread marker keeps showing even after read and revisit report?

Screen.Recording.2024-01-30.at.1.35.12.AM.mov

[jeremy-croff]

@jeremy-croff can you please explain the root cause in detail?

This has 2 bugs: (might have the same root cause though)

• why LHN text is not bolded when login first time after getting invited?
• why unread marker keeps showing even after read and revisit report?

Screen.Recording.2024-01-30.at.1.35.12.AM.mov

While both are adressed with my fix,

I will report back soon why the unread marker keeps showing in current main.
It has to do with the logic that determines unread within the report is seperate from the LHN.

[jeremy-croff]

@jeremy-croff can you please explain the root cause in detail?

This has 2 bugs: (might have the same root cause though)

• why unread marker keeps showing even after read and revisit report?

We grab the last read time from the report

App/src/pages/home/report/ReportActionsList.js

Line 235 in e2ddbcb

lastReadTimeRef.current = report.lastReadTime;

And compare the report actions against that timestamp for the unread marker in the chat. It sees the action has a later timestamp than the report read timestamp, and stores the ref.

App/src/pages/home/report/ReportActionsList.js

Line 369 in e2ddbcb

const isCurrentMessageUnread = isMessageUnread(reportAction, lastReadTimeRef.current);

Then when going over the chats, it marks it as unread here

App/src/pages/home/report/ReportActionsList.js

Line 382 in e2ddbcb

shouldDisplay = reportAction.reportActionID === currentUnreadMarker;

the welcome message has a later timestamp.

Following screenshots show this:

• why LHN text is not bolded when login first time after getting invited?

This flow is different from the the chat unread unread.
LHN logic only looks at report:

App/src/libs/ReportUtils.ts

Line 3517 in 0d0b0a8

return lastReadTime < lastVisibleActionCreated;

Where we just compare the timestamps from the report.
And as demonstrated are the same in this scenario.

Fixing the issue with my logic adresses both, as it will update both report and item timestamps.

[situchan]

updating in a few hrs

[situchan]

Ideally, this should be fixed in backend.
So report.lastVisibleActionCreated should be whisperAction.created when last visible action is whisperAction.
Currently, whisper actions are not considered as visible action in backend when calculate report.lastVisibleActionCreated.

If we wanna do frontend fix, @eh2077's proposal looks good.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[situchan]

I think this bug came from the fact that whisper action should not be visible in LHN as last message.

[thienlnam]

Ah interesting - thanks for the summary. We should fix this in the BE - though the query for determining visible report actions is quite complex. Not an urgent bug so going to change the priority

[lschurr]

Any update here @thienlnam?

[thienlnam]

I'm not currently working on this issue over other vip-vsb items, perhaps we can tie it to a wave and see if anyone is interested?

[lschurr]

Ok, got it. I'll review this later today.

[lschurr]

Asking for help here - https://expensify.slack.com/archives/C01SKUP7QR0/p1710870703703099

[lschurr]

Asking for a volunteer in Slack here: https://expensify.slack.com/archives/C066HJM2CAZ/p1712079432372279

[lschurr]

Haven't heard anything in the Slack thread - ideas on this one @thienlnam?

[lschurr]

Anything on this one @thienlnam? Are we cool leaving this unassigned since it's a low priority?

[thienlnam]

Nope, hasn't been a focus - I think it's fine to leave unassigned or even close for other priorities at this time

[lschurr]

Going to close this as not a priority for now.