[HOLD for payment 2024-02-09] IOU - Pay elsewhere button does nothing and console error shows up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .1.3.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [User A] Request money from User B
2. [User B] Click on IOU preview to go to IOU report
3. [User B] Click Pay elsewhere

Expected Result:

The request is paid successfully

Actual Result:

Nothing happens after clicking on Pay elsewhere. Console error shows up. On Android and iOS, app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363689_1706797625555.Bug6363660_1706795683853_20240201_175303__1_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[lakchote]

> When user requested money from within a specific report, we did not pass the specific reportID to the backend. Instead we always depended on what reportID has been saved in the chatReport.iouReportID key.
Looks like it might be #35246 cc @mountiny

EDIT: not the culprit.

[mountiny]

I dont think its related, this seems as backend issue

The moneyRequestReport is missing chatReportID key

in here

App/src/components/MoneyReportHeader.tsx

Line 203 in 9ab4fe9

},

[mountiny]

its in onyx, it will be the same fix as here https://github.com/Expensify/App/pull/35563/files#r1474670646 need to add the chatReportID to the memo

[aimane-chnaif]

I am not able to reproduce on main (pointed to production backend)

Screen.Recording.2024-02-01.at.4.45.30.PM.mov

[lakchote]

I am not able to reproduce on main

Hmm, that's odd I can reproduce it on main

payelsewhere.mov

[aimane-chnaif]

@lakchote is it pointed to staging or production backend?

[aimane-chnaif]

Strange. I reliably reproduced on staging but still not on main

Screen.Recording.2024-02-01.at.4.59.03.PM.mov

[lakchote]

Yes it looks like it's on staging only.

It was stated by @lanitochka17 😄

Reproducible in staging?: Y
Reproducible in production?: N

[mountiny]

I can reproduce on main, adding the chatReportID to the memo fixed it

[mountiny]

Ideally we can fix this in @rlinoz PR too #35563

[mountiny]

fix cped

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixing some buttons being unresponsive in ReportScreen #35563

If no regressions arise, payment will be issued on 2024-02-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@lakchote] The PR that introduced the bug has been identified. Link to the PR:
• [@lakchote] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@lakchote] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@lakchote] Determine if we should create a regression test for this bug.
• [@lakchote] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: