[HOLD for payment 2024-02-09] Chat - The "Pin" button becomes unresponsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.35-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Go to any conversation.
2, Click on the three dots in the right corner.
3, Click on the pin icon and observe that it is unresponsive

Expected Result:

The "Pin" button should be responsive when clicking on the pin icon from the dropdown in the conversation

Actual Result:

The "Pin" button is unresponsive when clicking on the pin icon from the dropdown in the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363678_1706796983044.pin.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pinned report isn't showing unpin option

What is the root cause of that problem?

It is a regression from #30168 where light weight report object gets created but we aren't setting the isPinned field.
https://github.com/Expensify/App/pull/30168/files#diff-dd4bfa50713397aca8cb40145317936ab0affe19abc2a9c24d6c8849ed75dc9bR173

What changes do you think we should make in order to solve the problem?

Add isPinned field with the value which we have in the onyx report data and also add it in the useMemo dependency.

isPinned: reportProp.isPinned,

App/src/pages/home/ReportScreen.js

Lines 173 to 203 in 9ab4fe9

	const report = useMemo(
	() => ({
	lastReadTime: reportProp.lastReadTime,
	reportID: reportProp.reportID,
	policyID: reportProp.policyID,
	lastVisibleActionCreated: reportProp.lastVisibleActionCreated,
	statusNum: reportProp.statusNum,
	stateNum: reportProp.stateNum,
	writeCapability: reportProp.writeCapability,
	type: reportProp.type,
	errorFields: reportProp.errorFields,
	isPolicyExpenseChat: reportProp.isPolicyExpenseChat,
	parentReportID: reportProp.parentReportID,
	parentReportActionID: reportProp.parentReportActionID,
	chatType: reportProp.chatType,
	pendingFields: reportProp.pendingFields,
	isDeletedParentAction: reportProp.isDeletedParentAction,
	reportName: reportProp.reportName,
	description: reportProp.description,
	managerID: reportProp.managerID,
	total: reportProp.total,
	nonReimbursableTotal: reportProp.nonReimbursableTotal,
	reportFields: reportProp.reportFields,
	ownerAccountID: reportProp.ownerAccountID,
	currency: reportProp.currency,
	participantAccountIDs: reportProp.participantAccountIDs,
	isWaitingOnBankAccount: reportProp.isWaitingOnBankAccount,
	iouReportID: reportProp.iouReportID,
	isOwnPolicyExpenseChat: reportProp.isOwnPolicyExpenseChat,
	notificationPreference: reportProp.notificationPreference,
	}),

[aimane-chnaif]

@hurali97 please check this

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[hurali97]

@aimane-chnaif I can take a look tomorrow morning 👍

[aimane-chnaif]

@hurali97 PR is already raised here
We should fix this urgently as deploy blocker.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

CP done!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixing some buttons being unresponsive in ReportScreen #35563

If no regressions arise, payment will be issued on 2024-02-09. 🎊