[HOLD for payment 2024-02-09] Expense - Submit button is green in the main chat and gray in the expense report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace
• Schedule submit is turned off

1. Go to workspace chat
2. Create a manual expense
3. Note that the submit button is green in the expense preview in the workspace chat
4. Click on the expense preview

Expected Result:

The submit button in the expense report is green

Actual Result:

The submit button in the expense report is gray.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363753_1706801157550.20240201_083255.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[luacmartins]

@Expensify/design can you confirm if they should be all green please?

[shawnborton]

cc @trjExpensify @JmillsExpensify

I would think they would both be the same color right? I could have sworn that we make the button NOT green if scheduled submit is on. Basically if it will auto submit for you, we don't highlight the button in green.

[mountiny]

yeah both should be same colour, green if you are the submitter, gray if scheduled submit is on or you are not the submitter.

[mountiny]

I think it might require same fix as here #35562 (comment)

[mountiny]

Yep adding chatReportID to the memo should fix this too #35563 (comment)

@rlinoz will add it I believe

[mountiny]

can be discussed in this thread https://expensify.slack.com/archives/C03TQ48KC/p1706800895520479

[trjExpensify]

yeah both should be same colour, green if you are the submitter, gray if scheduled submit is on or you are not the submitter.

Correct, agreed!

[luacmartins]

Nice, thanks for the discussion! So it seems like @rlinoz will be fixing this!

[mountiny]

fix cped

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixing some buttons being unresponsive in ReportScreen #35563

If no regressions arise, payment will be issued on 2024-02-09. 🎊