-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box #26347
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
I feel like this is an age-old issue that we used to run into a LOT. Checking on in #expensify-open-source |
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
@NicMendonca I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx |
Job added to Upwork: https://www.upwork.com/jobs/~01bb269a50709f3aa2 |
Current assignees @mallenexpensify and @NicMendonca are eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
📣 @h0u554m! 📣
|
Contributor details |
|
Contributor details |
You can either implement a brief delay (e.g., 1-2 seconds) to prevent the client from clicking the button while it's sending or change the button's icon to a loading indicator to indicate that the action is in progress. |
ProposalPlease re-state the problem that we are trying to solve in this issue.When a user rapidly enters text and tap the send message icon multiple times in quick succession, the compose box does not clear as expected. This results in the new message getting concatenated with the previously sent message text, creating a messy overlap in the compose box. What is the root cause of that problem?The root cause of this problem seems to be related to the asynchronous nature of the text handling and API call. As the user types, the Because of this delayed processing, when the user types and hits send rapidly, multiple calls to What changes do you think we should make in order to solve the problem?After some extensive analysis of the relevant codebase, I explored a couple of options to solve this issue, but wasn't able to implement them properly since I'm still not very familiar with the app, and, my simulator does not work as fast as I see the one in the video showing the bug. I was able to reproduce the bug, though, and I did come up with a simple solution that hopefully you consider accepting. I implemented a "versioning" strategy when rendering the Before FixScreen.Recording.2023-10-03.at.13.08.40.mp4After FixScreen.Recording.2023-10-02.at.23.04.03.mp4Contributor detailsYour Expensify account email: aolvera@andrux.net |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Second PR got merged |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
its a tough one but we getting through it |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-09. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@mountiny, both @situchan and @aimane-chnaif have been paid $2k, Is that correct? What regression tests do we need for this??!?! |
Not sure what are the best regression steps for this. I think its one of those we would raise over time if it comes back Has there been reliable reproduction steps? |
@situchan and @aimane-chnaif , from above, can you confirm this is correct?
I'm unaware of reliable reproduction steps. @hurali97 @kacper-mikolajczak @aimane-chnaif @situchan , any of you know? |
Not exactly sure about the amount. This was very old issue and maybe applies the same amount in issue title, similar to #10148? The size of PR was also large enough. Repro step is same as stated in OP. Our PR was supposed to fix this in most devices (#30168 (comment)) So I'd like to say: |
TestRail GH created - https://github.com/Expensify/Expensify/issues/371196
I'm going to leave as-is then and close this. Comment/reopen if you disagree. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The compose box should be scrubbed after each click on the send message icon
Actual Result:
The compose box doesn't have time to scrub after each click on the send icon and new text is added to the old text already sent
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.59
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6183207_Record_Android_CB.mp4
Bug6183207_Record_iOS_CB.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: