[$125] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Hover over workspace switcher

Expected Result:

The dropdown button will be visible

Actual Result:

The dropdown button is hardly visible when hovering over it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365101_1706895013722.20240202_232856__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e08e86679fe960fc
• Upwork Job ID: 1753533589875175424
• Last Price Increase: 2024-02-02

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[esh-g]

Screen.Recording.2024-02-02.at.11.31.53.PM.mov

How about we have it lighter instead of darker (for dark theme at least)

[luacmartins]

I don't think this is a blocker. Gonna demote it and we can get contributors to work on it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e08e86679fe960fc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace dropdown button is hardly visible when hovering over it

What is the root cause of that problem?

The root cause is the fill color here when the button is hovered:

App/src/components/WorkspaceSwitcherButton.tsx

Line 58 in cac0a85

fill: hovered ? theme.buttonHoveredBG : theme.icon,

the theme.buttonHoveredBG color is productDark500:

App/src/styles/theme/themes/dark.ts

Line 28 in cac0a85

buttonHoveredBG: colors.productDark500,

What changes do you think we should make in order to solve the problem?

We should change it to a lighter dark color in the dark mode, maybe to appBG (productDark100) or highlightBG (productDark200)

What alternative solutions did you explore? (Optional)

[s77rt]

We already have an issue for that #35618. We can close this cc @greg-schroeder

[luacmartins]

Closing in favor of #35618. Thanks for the link @s77rt