Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-02-02 #35673

Closed
github-actions bot opened this issue Feb 2, 2024 · 30 comments
Closed

Deploy Checklist: New Expensify 2024-02-02 #35673

github-actions bot opened this issue Feb 2, 2024 · 30 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Release Version: 1.4.36-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kbecciv kbecciv added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 2, 2024
@mvtglobally
Copy link

@francoisl @mountiny Has the build go through properly? I see some really old PRs in the checklist

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.36-0 🚀

@mountiny
Copy link
Contributor

mountiny commented Feb 2, 2024

All ready @mvtglobally

@luacmartins
Copy link
Contributor

Checked off #35683. Demoted to NAB.

@blimpich
Copy link
Contributor

blimpich commented Feb 2, 2024

Checking off #35690, demoting.

@neil-marcellini
Copy link
Contributor

@dangrous
Copy link
Contributor

dangrous commented Feb 2, 2024

Checking off #35681, demoting.

@amyevans
Copy link
Contributor

amyevans commented Feb 2, 2024

Demoting #35680

@luacmartins
Copy link
Contributor

Demoting #35728. Checked off

@luacmartins
Copy link
Contributor

Demoting #35686. Checked off.

@luacmartins
Copy link
Contributor

Demoted #35724. Checked off.

@francoisl
Copy link
Contributor

Demoted #35722 and tagged the design team in Slack to confirm if we need to change anything

@blimpich
Copy link
Contributor

blimpich commented Feb 2, 2024

#35733 is a dupe. Closed issue and checked off.

@francoisl
Copy link
Contributor

francoisl commented Feb 2, 2024

#35731 was demoted, checking it off
#35723 is a dupe goBack issue, closed
#35694 was demoted, checking off
#35736 was demoted and closed, checking off
#35738 demoted, checking off

@mvtglobally
Copy link

Regression is at 25% left

Quite a few PRs still pending validation and team is still working on issues exporting.

We will provide additional update tomorrow morning

@kbecciv
Copy link

kbecciv commented Feb 4, 2024

Regression is completed!

#34483 is failing #35772, repro in prod, checking off
#34495 is failing #34377 on mWeb, repro in prod, checking off
#35028 is failing #32400

Deploy Blockers:
#35687
#35698
#35701
#35720
#35729
#35730
#35732
#35739
#35745
#35747
#35748
#35749
#35750
#35752
#35753
#35754
#35755
#35757
#35758
#35759
#35761
#35763
#35764
#35765
#35766
#35767
#35771
#35776
#35777
#35782
#35783
#35785
#35787

@Julesssss
Copy link
Contributor

Checked off #35747 as a blocker -- can't reproduce.

@Julesssss
Copy link
Contributor

Checking off #35803 as a blocker, it is minor compared to the rest of today's blockers, we'll handle it as a typical issue in the meantime.

@marcaaron marcaaron self-assigned this Feb 5, 2024
@marcaaron
Copy link
Contributor

Checking off #35745 as we CP'd a fix to staging.

@marcaaron
Copy link
Contributor

Checking off #35843 as we determined it is already broken on production and the feature is behind a BETA

@thienlnam
Copy link
Contributor

Checking off #35765 as we just CPed a fix to staging

@marcaaron
Copy link
Contributor

We also CP'd a fix for 35850 so that's it for the blockers.

@marcaaron
Copy link
Contributor

This looks high for android - but there is no new data so I am guessing the chart is broken somehow...

2024-02-05_12-09-11

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests