[HOLD for payment 2024-03-20] [$500] Workspace - Title with /Chats and /Settings is not aligned properly with minimum font size

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Kill the app if it is in the background
2. Change device font size to the minimum
3. Relaunch New Expensify app
4. Note that "/ Chats" is not on the same line as Expensify logo
5. Tap Settings from the bottom
6. Note that "/ Settings" is not on the same line as Expensify logo
7. Select a workspace
8. Note that "Workspace / Settings" is aligned to the top (higher than usual)

Expected Result:

In Step 4, 6 and 8, when device font size is the minimum, the Expensify title will align accordingly

Actual Result:

In Step 4 and 6, "/ Chats" and "/Settings" are not on the same line as Expensify logo when device font size is minimum
In Step 8, "Workspace / Settings" is aligned to the top (higher than usual)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366880_1707064443025.Screen_Recording_20240203_180923_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016dcd74798af67988
• Upwork Job ID: 1754910426505916416
• Last Price Increase: 2024-02-06
• Automatic offers:
• Ollyws | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @sonialiap

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave8
CC @zanyrenney

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[mountiny]

Not a blocker, adding Design label to help us align on how this should behave as the system font sizes change.

[shawnborton]

oh boy, cc @Expensify/design on this one... I don't have a great answer, other than... what if we just made it so that this part of the app didn't change if system font settings changed?

Or in the very least, we should be making sure that everything maintains perfect vertical center alignment.

[dannymcclain]

Hmmmm yeah this is tricky. Seems like everything works as expected for non-Expensify workspaces right? Everything just scales down together?

Is there any possible way we could also scale down the wordmark in the same way? (This might be an absolutely nutty idea, just tossing it out there.)

what if we just made it so that this part of the app didn't change if system font settings changed?

I don't love the idea of of specifically and directly not supporting a user's choice. There's got to be another way. I just don't know if I have any good ideas for it right now.

we should be making sure that everything maintains perfect vertical center alignment.

This might be our best bet unless we can get that wordmark to scale along with the text. The titles won't sit on the same baseline anymore but at least they'd be vertically centered?

[shawnborton]

This might be our best bet unless we can get that wordmark to scale along with the text. The titles won't sit on the same baseline anymore but at least they'd be vertically centered?

Yeah, in the very least, let's just make sure the non-filtered view has the vertically centered alignment? As you mentioned, seems like that's the only one that has the very obvious bug here.

[dubielzyk-expensify]

Yeah, I agree that we need to scale it after user preference.

I wonder if we can scale like an image rather than text. So Expensify/Workspace name is treated as one element that we apply scale to rather than font-size?

[shawnborton]

Oh that's an interesting approach... Def would be curious to see a solution like that.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016dcd74798af67988

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

This issue has not been updated in over 15 days. @shawnborton, @Ollyws, @mountiny, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

Was merged

[sonialiap]

@mountiny since the PR has been merged, is it now waiting for the regression hold and payment or is this issue still in progress? Did automation skip the issue 🕵️ If it's on the payment stage then I'll update the labels/title

[Ollyws]

It's awaiting payment, Melvin seems to be having trouble these days.

[mountiny]

I think its in staging now so hopefully the automation will work soon

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix breadcumbs font auto scaling #36655

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

Original upwork job expired so I created a new one and sent out offers

@Ollyws Reviewer $500 - offer sent - please complete the checklist
@dukenv0307 Contributor $500 - offer sent

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#32221

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/32221/files#r1533419128

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Kill the app if it is in the background
2. Change device font size to the minimum
3. Relaunch New Expensify app
4. Verify that "/ Chats" is on the same line as Expensify logo
5. Tap Settings from the bottom
6. Verify that "/ Settings" is on the same line as Expensify logo
7. Select a workspace
8. Verify that "Workspace / Settings" is on the same line

Do we agree 👍 or 👎

[Ollyws]

Checklist complete and offer accepted!

[sonialiap]

Thanks Olly :)

Both payments made