-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Use keyForList in OptionsSelector's isSelected logic #35770
Conversation
@ntdiary I don't think this requires a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-04.at.3.15.23.PM.movAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-02-04.at.3.12.52.PM.movMacOS: Desktop |
taking screenshots now... |
I had trouble with the android build. I checked, web, ios and desktop builds and they're all working! thank you for the quick PR! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Use keyForList in OptionsSelector's isSelected logic (cherry picked from commit 0ae07be)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.36-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀
|
Details
Use keyForList instead of accountID/reportID/policyID. Those IDs are already set as the keyForList in their corresponding lists. I found that only the payee is missing the keyForList which I added.
Fixed Issues
$ #35701
PROPOSAL: #35701 (comment)
Tests
Test 1: Group chat & Split in group
Test 2: Category / Tag / Tax Picker
Test 3: Report and Invoice Fields - Requires a workspace with "Report and Invoice Fields" enabled and have a dropdown field
Test 4: Workspace Switcher
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Test 1: Group chat & Split in group
web.-.Group.chat.Split.in.group.mov
Test 2: Category / Tag / Tax Picker
web.-.Category.Tag.Tax.Picker.mov
Test 3: Report and Invoice Fields
web.-.Report.and.Invoice.Fields.mov
Test 4: Workspace Switcher
web.-.Workspace.Switcher.mov
MacOS: Desktop
Screen.Recording.2024-02-04.at.3.19.19.PM.mov