-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split bill participant option select circle outline #35028
Fix split bill participant option select circle outline #35028
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
<SelectCircle | ||
isChecked={item.isSelected} | ||
selectCircleStyles={styles.ml0} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this happen on participants page too, so I fix it too.
@bernhardoj Can you merge main? |
Merged with main |
Reviewer Checklist
Screenshots/VideosAndroid: NativeNA Android: mWeb ChromeNA iOS: NativeNA iOS: mWeb SafariNA MacOS: Chrome / SafariScreen.Recording.2024-02-01.at.9.00.12.AM.movMacOS: DesktopScreen.Recording.2024-02-01.at.9.01.55.AM.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@bernhardoj @shubham1206agra QA raised that this is still not fixed in staging. Could you verify |
I am still seeing this as fixed. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀
|
Details
The select circle outline is in square and has some space on the left.
Fixed Issues
$ #32400
PROPOSAL: #32400 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Web/Desktop/Android mWeb
iOS/Andoid/mWeb iOS
There is no blue focus outline
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-01-24.at.12.44.51.mov
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-01-24.at.12.41.39.mov
MacOS: Desktop
Screen.Recording.2024-01-24.at.12.42.12.mov