-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Workspace - Member list blinks briefly after inviting member to the workspace #35692
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @robertjchen ( |
We think that this bug might be related to #wave 5. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The member list page blinks after adding a new member. What is the root cause of that problem?After adding a new member, we will navigate to the workspace members.
But we have a logic here to change the navigation type to PUSH if the destination is a central pane navigator (which is true for members page) and the current central pane is not a report screen, so we always push the members page to the stack, thus the page "blinks". App/src/libs/Navigation/linkTo.ts Lines 163 to 179 in 3ab4e6e
What changes do you think we should make in order to solve the problem?We should check whether the route destination is the same as the current central pane route instead of check whether it's a report screen or not. If it's the same, then don't push it.
|
@lanitochka17 Looks like you want to ping @dylanexpensify instead of me |
@DylanDylann I'm sorry, you're right |
@robertjchen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@dylanexpensify Is there anything special we have to do for issues relating to the wave? #35692 (comment) |
looking! |
@robertjchen, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this? |
I think it'll be wave6, and low priority but we can open it up |
Job added to Upwork: https://www.upwork.com/jobs/~019b4737b731439c29 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
🙏 |
I can't reproduce it in the latest Screen.Recording.2024-02-17.at.02.44.07.mp4 |
Thanks for the test @mollfpr , I think we may be all set here for now 👀 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The member list will not blink
Actual Result:
The member list blinks briefly
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6365145_1706897084155.20240203_001835.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: