Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android – Back button redirect to LHN from IOU report preview in WS and unable to open WS chat #35738

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 2, 2024 · 7 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open New Expensify app.
  2. Log in
  3. Request money from your own workspace;
  4. Navigate to the workspace chat;
  5. On the expense report preview, open the Settlement button's dropdown;
  6. Select an option different from the currently selected;
  7. Click on the report preview to open the Expense Report view;
  8. Tap on the Back button arrow on the header

Expected Result:

Back button redirects to parent WS chat from expense report preview

Actual Result:

Back button redirects to LHN from expense report preview in WS and unable to open WS chat again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365377_1706911306046.Staging.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave6
CC @greg-schroeder

@allgandalf
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

What is the root cause of that problem?

OnBackButtonPress is missing in HeaderWithBackButton component in all the ReportView Page

What changes do you think we should make in order to solve the problem?

Pass the prop onBackButtonPress={() => Navigation.goBack()} in HeaderWithBackButtonin all the ReportView Page pertaining this bug.

What alternative solutions did you explore? (Optional)

N/A

@robertjchen
Copy link
Contributor

Part of #35626 and being addressed

@robertjchen robertjchen added Daily KSv2 and removed Hourly KSv2 labels Feb 2, 2024
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

@robertjchen Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertjchen
Copy link
Contributor

Closing in favor of #35626 as it is being actively handled there.

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants