Fix/34434 #35218

Tony-MK · 2024-01-26T03:35:47Z

Details

Fixed Issues

$ #34434
PROPOSAL: #34434 (comment)

Tests

Go offline.
Create a manual request with a user without any unpaid money requests.
Go to the user's main chat f had not been redirected.
Verify the report preview is dimmed.
Note the opacity of the report preview.
Create another manual request with the same user.
Same as step 3, go to the user's main chat if had not been redirected.
Verify the opacity of the report preview is identical to its opacity from step 4.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Create a manual request with a user without any unpaid money requests.
Go to the user's main chat f had not been redirected.
Verify the report preview is dimmed.
Note the opacity of the report preview.
Create another manual request with the same user.
Same as step 3, go to the user's main chat if had not been redirected.
Verify the opacity of the report preview is identical to its opacity from step 4.

QA Steps

Go offline.
Create a manual request with a user without any unpaid money requests.
Go to the user's main chat f had not been redirected.
Verify the report preview is dimmed.
Note the opacity of the report preview.
Create another manual request with the same user.
Same as step 3, go to the user's main chat if had not been redirected.
Verify the opacity of the report preview is identical to its opacity from step 4.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mov

Android: mWeb Chrome

Android.-.mWeb.mov

iOS: Native

iOS.-.Native.mp4

iOS: mWeb Safari

iOS.-.mWeb.mp4

MacOS: Chrome / Safari

macOS.-.Chrome.mov

MacOS: Desktop

macOS.-.Desktop.mov

…ffline

…reated offline" This reverts commit a213454.

…ffline

Dev/34434

melvin-bot · 2024-01-26T03:35:51Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2024-01-26T11:16:35Z

Create a manual request with a user with no prior chat.

Why is it a requirement to have no prior chat?

cubuspl42 · 2024-01-26T11:19:30Z

like in step 4

Don't you mean "compared to its opacity from step 4"?

src/components/ReportActionItem/ReportPreview.js

Tony-MK · 2024-01-26T21:51:35Z

Why is it a requirement to have no prior chat?

My apologies, @cubuspl42.

I aimed to include the actions performed in the issue.

The steps should be all right.

Should I also redo the videos?

I don't mind.

Thanks 😄

cubuspl42 · 2024-01-29T09:02:14Z

Should I also redo the videos?

No need.

cubuspl42 · 2024-01-29T09:40:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

money-request-double-dim-android-compressed.mp4

Android: mWeb Chrome

money-request-double-dim-android-web-compressed.mp4

iOS: Native

money-request-double-dim-ios-compressed.mp4

iOS: mWeb Safari

money-request-double-dim-ios-web-compressed.mp4

MacOS: Chrome / Safari

money-request-double-dim-web-converted.mp4

MacOS: Desktop

cubuspl42

Please merge main, hopefully it will make the performance tests pass

…into fix/34434

cubuspl42 · 2024-01-31T09:00:38Z

The linter is complaining 🙁

Update ReportPreview.tsx

cubuspl42 · 2024-02-01T11:20:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

money-request-double-dim-android-compressed.mp4

Android: mWeb Chrome

money-request-double-dim-android-web-compressed.mp4

iOS: Native

money-request-double-dim-ios-compressed.mp4

iOS: mWeb Safari

money-request-double-dim-ios-web-compressed.mp4

MacOS: Chrome / Safari

money-request-double-dim-web-converted.mp4

MacOS: Desktop

srikarparsi

lgtm

OSBotify · 2024-02-01T22:56:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T22:53:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Tony-MK added 6 commits January 14, 2024 05:35

fix: Report preview more grayed when two money requests are created o…

a213454

…ffline

Revert "fix: Report preview more grayed when two money requests are c…

501bd34

…reated offline" This reverts commit a213454.

fix: Report preview more grayed when two money requests are created o…

52143a0

…ffline

Merge branch 'Expensify:main' into dev/34434

602c4f1

Merge branch 'Expensify:main' into dev/34434

a1b27df

Merge pull request #24 from Tony-MK/dev/34434

42eee15

Dev/34434

Tony-MK requested a review from a team as a code owner January 26, 2024 03:35

melvin-bot bot removed the request for review from a team January 26, 2024 03:35

melvin-bot bot requested a review from cubuspl42 January 26, 2024 03:35

prettier

64697c6

Tony-MK mentioned this pull request Jan 26, 2024

[$500] IOU - IOU preview becomes more grayed out when creating another request to a pending request #34434

Closed

6 tasks

Tony-MK commented Jan 26, 2024

View reviewed changes

src/components/ReportActionItem/ReportPreview.js Outdated Show resolved Hide resolved

cubuspl42 suggested changes Jan 29, 2024

View reviewed changes

Tony-MK added 5 commits January 31, 2024 02:49

Merge branch 'fix/34434'

c9f6665

Merge branch 'Expensify:main' into fix/34434

e1bcedc

fix

40c979c

Merge branch 'fix/34434' of https://github.com/Tony-MK/Expensify-App …

271c6c5

…into fix/34434

Merge branch 'Expensify:main' into fix/34434

026e062

Tony-MK added 4 commits January 31, 2024 17:33

prettier

5b6cf79

Merge branch 'Expensify:main' into fix/34434

32aae52

Update ReportPreview.tsx

e3823c1

Merge pull request #28 from Tony-MK/Tony-MK-fix/34434-1

a45c2a1

Update ReportPreview.tsx

Tony-MK requested a review from cubuspl42 January 31, 2024 23:29

cubuspl42 approved these changes Feb 1, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi February 1, 2024 11:21

srikarparsi approved these changes Feb 1, 2024

View reviewed changes

srikarparsi merged commit ff85cdf into Expensify:main Feb 1, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 2, 2024

Deploy Checklist: New Expensify 2024-02-02 #35673

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/34434 #35218

Fix/34434 #35218

Tony-MK commented Jan 26, 2024 •

edited

Loading

melvin-bot bot commented Jan 26, 2024

cubuspl42 commented Jan 26, 2024

cubuspl42 commented Jan 26, 2024

Tony-MK commented Jan 26, 2024

cubuspl42 commented Jan 29, 2024

cubuspl42 commented Jan 29, 2024

cubuspl42 left a comment

cubuspl42 commented Jan 31, 2024

cubuspl42 commented Feb 1, 2024

srikarparsi left a comment

OSBotify commented Feb 1, 2024

OSBotify commented Feb 5, 2024

Fix/34434 #35218

Fix/34434 #35218

Conversation

Tony-MK commented Jan 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 26, 2024

cubuspl42 commented Jan 26, 2024

cubuspl42 commented Jan 26, 2024

Tony-MK commented Jan 26, 2024

cubuspl42 commented Jan 29, 2024

cubuspl42 commented Jan 29, 2024

Reviewer Checklist

Screenshots/Videos

cubuspl42 left a comment

Choose a reason for hiding this comment

cubuspl42 commented Jan 31, 2024

cubuspl42 commented Feb 1, 2024

Reviewer Checklist

Screenshots/Videos

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 1, 2024

OSBotify commented Feb 5, 2024

Tony-MK commented Jan 26, 2024 •

edited

Loading