fix: Selecting last possible member to group hides selected members. #34847

Krishna2323 · 2024-01-20T07:09:23Z

Details

Fixed Issues

$ #34111
PROPOSAL: #34111 (comment)

Tests

Click on the green + button
Click on the "Start chat" option
Make a search to narrow option, f.e. "pronin"
Select 8 random users from the search list
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8
Request money > Enter any amount in manual tab > Click Next
Split with 8 users > Search any member
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8

Verify that no errors appear in the JS console

Offline tests

Click on the green + button
Click on the "Start chat" option
Make a search to narrow option, f.e. "pronin"
Select 8 random users from the search list
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8
Request money > Enter any amount in manual tab > Click Next
Split with 8 users > Search any member
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8

QA Steps

Click on the green + button
Click on the "Start chat" option
Make a search to narrow option, f.e. "pronin"
Select 8 random users from the search list
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8
Request money > Enter any amount in manual tab > Click Next
Split with 8 users > Search any member
Verify all selected members are shown even if there is a search term & search result appears when selected member is less than 8

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-01-20T07:09:28Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-01-20T07:16:25Z

Facing issues when trying to login in mWeb, will update the screenshots once I can login.

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

c3024 · 2024-01-22T09:51:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

maxParticipantsAndroid.mp4

Android: mWeb Chrome

maxParticipantsAndroidChrome.mp4

maxParticipantsAndroidChrome2.mp4

iOS: Native

maxiOSNative.mp4

iOS: mWeb Safari

maxParticipantsiOSSafari.mp4

MacOS: Chrome / Safari

maxChrome.mp4

MacOS: Desktop

maxDesktop.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-01-23T11:00:05Z

@c3024 all done!

c3024

LGTM

c3024 · 2024-01-25T10:38:12Z

Please change this step in the Tests to the step you followed - either The search string you used or the step you followed.

Make a search to narrow option, f.e. "pronin"

Also PR author checklist is failing. Please check all boxes.

@Krishna2323

Beamanator

Looking great! A few small suggestions, I think it would be nice to clean up the reused code & think about reordering the params of formatSectionsFromSearchTerm, but curious to hear what y'all think

src/libs/OptionsListUtils.js

src/pages/NewChatPage.js

Beamanator · 2024-01-25T12:02:32Z

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

@@ -259,10 +260,15 @@ function MoneyRequestParticipantsSelector({
    );

    // When search term updates we will fetch any reports


Can we also update this comment to explain the new changes?

Also since this is pretty much copy / pasted in 3 files, should we make it a reusable lib?

Yes, I think we should do both.

cc: @Krishna2323

@c3024, comments have been updated, can you help me understanding what do you mean by making it reusable lib, the setSearchTermAndSearchInServer uses useCallback & setState.

We extract this

const setSearchTermAndSearchInServer = useCallback( (text = '') => { if (text && !maxParticipantsReached) { Report.searchInServer(text); } setSearchTerm(text); }, [maxParticipantsReached], );

to a function in OptionListUtils.ts (or a more appropriate file) and use it in the three pages. @Krishna2323

@c3024, I believe it will over complicate things, as we need to use useCallback because we pass it to OptionsSelector.

Otherwise the option seems to create a util function that returns a function which will be used inside useCallback but as I said it will complicate things. Current implementation looks simpler to me and its just few lines of code, so I don't think we should extract few lines and still use useCallback which is a must.

How about a custom hook like this?

import { useCallback } from 'react'; import * as Report from '@userActions/Report'; const useSearchTermAndSearch = (setSearchTerm, maxParticipantsReached) => { const setSearchTermAndSearchInServer = useCallback( (text = '') => { if (text && !maxParticipantsReached) { Report.searchInServer(text); } setSearchTerm(text); }, [maxParticipantsReached, setSearchTerm] ); return setSearchTermAndSearchInServer; }; export default useSearchTermAndSearch;

and use it in the pages like this

const setSearchTermAndSearchInServer = useSearchTermAndSearch(setSearchTerm, maxParticipantsReached);

WDYT? @Beamanator

I like that plan @c3024 👍 looks like we have a decent amount of custom hooks in the src/hooks directory, so this would be a nice one to add

@c3024, can you pls review once, created the hook and tested.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

…a2323/issue/34111

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Beamanator

Code looks good to me! But yes let's test again before we merge!

c3024

Tested again and works well.

selectLastWeb.mp4

selectLastDesktop.mp4

selectLastAndroid.mp4

selectLastiOS.mp4

Errors/warnings in the videos are also on main

LGTM

Beamanator

Amazing! LGTM!

OSBotify · 2024-02-01T12:30:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T22:53:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Krishna2323 added 2 commits January 20, 2024 12:21

fix: Selecting last possible member to group hides selected members.

1720478

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

comment added.

1176d22

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner January 20, 2024 07:09

melvin-bot bot requested review from c3024 and removed request for a team January 20, 2024 07:09

c3024 reviewed Jan 21, 2024

View reviewed changes

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js Outdated Show resolved Hide resolved

minor fix.

89c96b1

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

c3024 approved these changes Jan 25, 2024

View reviewed changes

melvin-bot bot requested a review from Beamanator January 25, 2024 10:36

Beamanator requested changes Jan 25, 2024

View reviewed changes

Krishna2323 added 8 commits January 26, 2024 18:49

fix: ordering of formatSectionsFromSearchTerm defauls parameters.

47e6c4f

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

fix: comments.

7191323

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

f924ea0

…a2323/issue/34111

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

b04e153

…a2323/issue/34111

fix: code updated due to merge conflicts.

efa6bfa

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

comment updated for formatSectionsFromSearchTerm.

40b30f0

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

update: callback function to hook.

5b42bdf

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/34111

ec468ed

Beamanator approved these changes Jan 31, 2024

View reviewed changes

c3024 approved these changes Feb 1, 2024

View reviewed changes

melvin-bot bot requested a review from Beamanator February 1, 2024 11:58

Beamanator approved these changes Feb 1, 2024

View reviewed changes

Beamanator merged commit 70dd251 into Expensify:main Feb 1, 2024
18 checks passed

github-actions bot mentioned this pull request Feb 2, 2024

Deploy Checklist: New Expensify 2024-02-02 #35673

Closed

shubham1206agra mentioned this pull request Feb 2, 2024

Group - All recents users selected when clicking on "Add to group" #35701

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Selecting last possible member to group hides selected members. #34847

fix: Selecting last possible member to group hides selected members. #34847

Krishna2323 commented Jan 20, 2024 •

edited

Loading

melvin-bot bot commented Jan 20, 2024

Krishna2323 commented Jan 20, 2024

c3024 commented Jan 22, 2024 •

edited

Loading

Krishna2323 commented Jan 23, 2024

c3024 left a comment

c3024 commented Jan 25, 2024

Beamanator left a comment

Beamanator Jan 25, 2024

Beamanator Jan 25, 2024

c3024 Jan 26, 2024

Krishna2323 Jan 28, 2024

c3024 Jan 28, 2024

Krishna2323 Jan 29, 2024

c3024 Jan 29, 2024

Beamanator Jan 30, 2024

Krishna2323 Jan 31, 2024

Beamanator left a comment

c3024 left a comment

Beamanator left a comment

OSBotify commented Feb 1, 2024

OSBotify commented Feb 5, 2024

		@@ -259,10 +260,15 @@ function MoneyRequestParticipantsSelector({
		);

		// When search term updates we will fetch any reports

fix: Selecting last possible member to group hides selected members. #34847

fix: Selecting last possible member to group hides selected members. #34847

Conversation

Krishna2323 commented Jan 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 20, 2024

Krishna2323 commented Jan 20, 2024

c3024 commented Jan 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Krishna2323 commented Jan 23, 2024

c3024 left a comment

Choose a reason for hiding this comment

c3024 commented Jan 25, 2024

Beamanator left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

c3024 left a comment

Choose a reason for hiding this comment

LGTM

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 1, 2024

OSBotify commented Feb 5, 2024

Krishna2323 commented Jan 20, 2024 •

edited

Loading

c3024 commented Jan 22, 2024 •

edited

Loading