[Wave 8] [Ideal Nav] Workspace - Workspace avatar switches from one to another when creating a new workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings from the bottom
3. Click New workspace

Expected Result:

The workspace avatar will be constant

Actual Result:

The workspace avatar switches from one to another

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365162_1706897723871.20240203_002546.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a0963c63b3685ca
• Upwork Job ID: 1753494083453640704
• Last Price Increase: 2024-02-02

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010a0963c63b3685ca

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace avatar switches from one to another when creating a new workspace

What is the root cause of that problem?

The main problem with issue is that when we create workspace we are using createDraftInitialWorkspace and generate policyDraft for workspace

App/src/libs/actions/App.ts

Lines 330 to 343 in 1c435ca

	function createWorkspaceWithPolicyDraftAndNavigateToIt(policyOwnerEmail = '', policyName = '', transitionFromOldDot = false, makeMeAdmin = false) {
	const policyID = Policy.generatePolicyID();
	Policy.createDraftInitialWorkspace(policyOwnerEmail, policyName, policyID, makeMeAdmin);
	Navigation.isNavigationReady()
	.then(() => {
	if (transitionFromOldDot) {
	// We must call goBack() to remove the /transition route from history
	Navigation.goBack(ROUTES.HOME);
	}
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));
	})
	.then(endSignOnTransition);
	}

But when we navigate to the screen with the workspace details we are using policy which is currently still empty

App/src/pages/workspace/WorkspaceOverviewPage.js

Line 53 in 80dc8cb

function WorkspaceOverviewPage({policy, currencyList, route}) {

As a result, we have a short period of time while we wait for the policy to be filled out

What changes do you think we should make in order to solve the problem?

To fix this issue we can update WorkspaceOverviewPage and when policy is not available yet we will use policyDraft

For example

const policy = _.isEmpty(policyCurrent) ? policyDraft : policyCurrent;

What alternative solutions did you explore? (Optional)

As alternative we can update createDraftInitialWorkspace and add using ONYXKEYS.COLLECTION.POLICY

[arosiclair]

Asking about this internally here

[arosiclair]

Seems to be not a bug. The avatar color should change depending on the name of the workspace. Closing this out