Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Thread - Some of the threads can't be opened from the LHN #35914

Closed
2 of 6 tasks
lanitochka17 opened this issue Feb 6, 2024 · 24 comments
Closed
2 of 6 tasks

[$500] Thread - Some of the threads can't be opened from the LHN #35914

lanitochka17 opened this issue Feb 6, 2024 · 24 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34640

Action Performed:

  1. Navigate to any chat with a "hidden" user
  2. Write 5 text messages and reply in thread for each
  3. Go to the LHN and open all of the threads

Expected Result:

I should be able to open any thread

Actual Result:

Some of the threads can't be opened from the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369468_1707233930280.Stpc4893.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0143ac6740a81b3d9a
  • Upwork Job ID: 1754962173583876096
  • Last Price Increase: 2024-02-20
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

Issue is not reproducible in Production:

0-02-01-dae044ee83c572297efeeef82e99b4b10d3eaf0d83b29af5a63eb19740cc4d08_c5ca308e2e7c7644.1.mp4

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@amyevans
Copy link
Contributor

amyevans commented Feb 6, 2024

Was able to repro on staging iOS on my phone. Still fighting with simulators so that I can get more insight into the error

@amyevans
Copy link
Contributor

amyevans commented Feb 6, 2024

A few observations:

  • It's irrelevant whether the chat is with a "hidden" user or a known user
  • The issue only occurs after the initial thread creation, once you navigate around a bit more it is no longer present

@amyevans
Copy link
Contributor

amyevans commented Feb 6, 2024

Anyway I don't think this needs to be a deploy blocker, going to demote it and open up for external help.

@amyevans amyevans added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@amyevans amyevans added the External Added to denote the issue can be worked on by a contributor label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0143ac6740a81b3d9a

@melvin-bot melvin-bot bot changed the title Thread - Some of the threads can't be opened from the LHN [$500] Thread - Some of the threads can't be opened from the LHN Feb 6, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

Any update here @cubuspl42?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 9, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 12, 2024

@amyevans are we just waiting on proposals right now?

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@amyevans
Copy link
Contributor

Yep seeking proposals

@cubuspl42
Copy link
Contributor

I have nothing to say, awaiting proposals 🙂

Copy link

melvin-bot bot commented Feb 13, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 15, 2024

Still waiting on proposals.

@melvin-bot melvin-bot bot removed the Overdue label Feb 15, 2024
@Victor-Nyagudi
Copy link
Contributor

Is this still reproducible?

Everything's working fine on my end.

@melvin-bot melvin-bot bot added the Overdue label Feb 18, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

@cubuspl42, @amyevans, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@lschurr
Copy link
Contributor

lschurr commented Feb 19, 2024

Hm is this still broken @amyevans @cubuspl42?

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@cubuspl42
Copy link
Contributor

As this is a recurring aspect of multiple issues, I confirmed on Slack that this is the responsibility of QA and BZ to verify whether the issue is reproducible when there's doubt.

Copy link

melvin-bot bot commented Feb 20, 2024

@cubuspl42 @amyevans @lschurr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@amyevans
Copy link
Contributor

I retested as well and can't repro, let's close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants