Implement get all ancestor of the thread #34640

dukenv0307 · 2024-01-17T11:08:43Z

Details

Implement get all ancestor of the thread

Fixed Issues

$ #32618
PROPOSAL: #32618 (comment)

Tests

Open any report
Send a message
Reply in the thread of this message
Report steps 2-3 serval times
Verify that in each thread, all ancestors of this thread are displayed
Click on any ancestor action, and verify that we go to the current thread of this action

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Open any report
Send a message
Reply in the thread of this message
Report steps 2-3 serval times
Verify that in each thread, all ancestors of this thread are displayed
Click on any ancestor action, and verify that we go to the current thread of this action
Test these step above with an account that has many reports and report actions.
Verify that all ancestor actions are displayed as well.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-17.at.17.57.44.mov

Android: mWeb Chrome

Screen.Recording.2024-01-17.at.17.53.57.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-01-17.at.17.47.08.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-17.at.17.45.02.mov

MacOS: Desktop

Screen.Recording.2024-01-17.at.18.07.28.mov

melvin-bot · 2024-01-17T11:09:03Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2024-01-19T18:03:11Z

I can't mark unread the parent ancestor on a one-level thread

Screen.Recording.2024-01-19.at.23.11.34.mp4

The marker position seems wrong. The marker should be on the top of the report action.

Screen.Recording.2024-01-19.at.23.14.07.mp4

mollfpr · 2024-01-19T18:11:19Z

src/pages/home/report/ReportActionItemParentAction.js

-            canEvict: false,
+        allReports: {
+            key: ONYXKEYS.COLLECTION.REPORT,
+            selector: reportSelector,


Why do we need to make a selection here even though the props are not used?

@mollfpr The reason to make a selection here is to decrease re-render of this component. We have another solution which is to use memo to only compare the ancestors. What do you think?

I think using memo will be ideal. We already use it for several components, which fits what we are trying to do here.

dukenv0307 · 2024-01-22T05:47:55Z

I can't mark unread the parent ancestor on a one-level thread
The marker position seems wrong. The marker should be on the top of the report action.

Fixed these cases.

mollfpr · 2024-01-24T12:51:20Z

@dukenv0307 Friendly bump on to update using memo and also fixed the conflicts. Thanks!

dukenv0307 · 2024-01-24T12:52:30Z

Thanks I will update in the early morning tomorrow.

dukenv0307 · 2024-01-25T09:59:40Z

@mollfpr I updated. Please help to review again.

mollfpr

Mark unread the ancestor is randomly mark unread the message in other reports.

Screen.Recording.2024-01-25.at.23.58.27.mp4

dukenv0307 · 2024-01-26T03:17:56Z

Mark unread the ancestor is randomly mark unread the message in other reports.

@mollfpr As I see the mark as unread work correct. when we mark as unread an ancestor, the current report of this action will be marked as unread in LHN. Correct me if I missed something.

mollfpr · 2024-01-26T06:13:58Z

@dukenv0307 You're right! My bad; I should have paid more attention to which parent action and the report. I'll finish the testing and recording then!

mollfpr · 2024-01-26T06:21:07Z

@dukenv0307 Could you check the failing performance test?

dukenv0307 · 2024-01-26T09:19:47Z

@mollfpr Passed test after merge newest main

mollfpr

Almost looks good. One more things to clean up the warning.

src/pages/home/report/ReportActionItemParentAction.tsx

mollfpr · 2024-01-29T05:13:07Z

src/pages/home/report/ReportActionItemParentAction.tsx

+                        onClose={() => Report.navigateToConciergeChatAndDeleteReport(ancestor.report.reportID)}
+                    >
+                        <ReportActionItem
+                            key={ancestor.reportAction.reportActionID}


It's still showing the warning. We might move it to the above component to clear the warning.

@mollfpr I updated.

mollfpr · 2024-01-29T06:02:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

34640.Android.mp4

Android: mWeb Chrome

34640.mWeb-Chrome.mp4

iOS: Native

34640.iOS.mov

iOS: mWeb Safari

34640.mWeb-Safari.mov

MacOS: Chrome / Safari

34640.Web.mp4

MacOS: Desktop

34640.Desktop.mp4

marcaaron · 2024-02-01T19:56:05Z

Thanks for the changes @dukenv0307. Went through and resolved a bunch of comments. I believe most of my remaining comments are minor. But we're still failing the "Reassure Performance Tests". I'll try to re-run them now.

marcaaron · 2024-02-01T20:37:25Z

@dukenv0307 We need to merge main here to fix the failing Reassure Performance Tests / perf-tests action.

dukenv0307 · 2024-02-02T03:19:40Z

@marcaaron Merged main and the test is passed now.

Co-authored-by: Luthfi <luthfi.ufi14@gmail.com>

mollfpr

Updated test recordings

It feels a bit slow on the Android when navigating through the thread, but it also does the same when I run on the main.

Screenshots/Videos

Android: Native

34640.Android.mov

Android: mWeb Chrome

34640.mWeb-Chrome.mov

iOS: Native

34640.iOS.mov

iOS: mWeb Safari

34640.mWeb-Safari.mov

MacOS: Chrome / Safari

34640.Web.mp4

MacOS: Desktop

34640.Desktop.mp4

marcaaron

Thanks for the changes and your fast work here!

OSBotify · 2024-02-02T18:25:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:09:10Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:30:55Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

lanitochka17 · 2024-02-06T16:04:25Z

This PR is failing because of issue #35914

The issue is reproducible in: Android, IOS

Bug6369468_1707233930280.Stpc4893.1.mp4

Julesssss · 2024-02-07T09:25:13Z

This PR is failing because of issue #35914

Just noting that the linked issue was demoted from being a blocker, so I'm not going to hold the release on this

OSBotify · 2024-02-07T09:51:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

s77rt · 2024-04-26T15:14:23Z

src/pages/home/report/ReportActionItemParentAction.tsx

+                onyxSubscribe({
+                    key: `${ONYXKEYS.COLLECTION.REPORT}${ancestorReportID}`,
+                    callback: () => {
+                        setAllAncestors(ReportUtils.getAllAncestorReportActions(report, shouldHideThreadDividerLine));
+                    },
+                }),


This does not follow our Onyx practices. Components should use withOnyx and not Onyx.connect

Could possibly have been a performance optimization? If we can explore getting rid of it that would be 👍

Components should use withOnyx and not Onyx.connect

Or useOnyx is a good option too now.

rushatgabhane · 2024-08-21T21:46:30Z

src/libs/ReportUtils.ts

@@ -4663,6 +4675,78 @@ function shouldDisableThread(reportAction: OnyxEntry<ReportAction>, reportID: st
    );
 }

+function getAllAncestorReportActions(report: Report | null | undefined, shouldHideThreadDividerLine: boolean): Ancestor[] {


This PR caused an issue - #41519

Detailed root cause here - #41519 (comment)

implement get all ancestor of the thread

e96ce99

dukenv0307 marked this pull request as ready for review January 17, 2024 11:08

dukenv0307 requested a review from a team as a code owner January 17, 2024 11:08

melvin-bot bot requested review from mollfpr and removed request for a team January 17, 2024 11:09

mollfpr reviewed Jan 19, 2024

View reviewed changes

dukenv0307 added 3 commits January 22, 2024 11:45

Merge branch 'main' into fix/32618

dc794ea

get correct reportID when mark as unread

07ccc0c

correctly logic check unread

ce57da7

resolve conflict and use memo to prevent re-render

dbdb166

dukenv0307 added 2 commits January 25, 2024 18:19

Merge branch 'main' into fix/32618

44337c1

remove unuse prop

40693fb

mollfpr reviewed Jan 25, 2024

View reviewed changes

dukenv0307 added 2 commits January 26, 2024 14:42

Merge branch 'main' into fix/32618

c0f27d5

Merge branch 'main' into fix/32618

6a876e4

mollfpr reviewed Jan 26, 2024

View reviewed changes

src/pages/home/report/ReportActionItemParentAction.tsx Show resolved Hide resolved

merge main and fix warning

bfffe59

mollfpr reviewed Jan 29, 2024

View reviewed changes

Merge branch 'main' into fix/32618

c1725c9

marcaaron assigned dukenv0307 Feb 1, 2024

marcaaron self-requested a review February 1, 2024 19:46

marcaaron previously approved these changes Feb 1, 2024

View reviewed changes

Merge branch 'main' into fix/32618

44e36c6

Update src/pages/home/report/ReportActionsListItemRenderer.js

9b9d8aa

Co-authored-by: Luthfi <luthfi.ufi14@gmail.com>

dukenv0307 dismissed marcaaron’s stale review via 9b9d8aa February 2, 2024 03:23

mollfpr approved these changes Feb 2, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron February 2, 2024 09:08

marcaaron approved these changes Feb 2, 2024

View reviewed changes

marcaaron merged commit 3a610af into Expensify:main Feb 2, 2024
18 checks passed

abekkala mentioned this pull request Feb 5, 2024

[HOLD for payment 2024-02-14] [$500] MEDIUM: Show full thread ancestry (front end, 1/2) #32618

Closed

github-actions bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks

lanitochka17 mentioned this pull request Feb 6, 2024

[$500] Thread - Some of the threads can't be opened from the LHN #35914

Closed

6 tasks

s77rt reviewed Apr 26, 2024

View reviewed changes

kmbcook mentioned this pull request May 3, 2024

[HOLD for payment 2024-08-19] [$250] Expense - Payment options displayed before submitting in thread created inside details page #41519

Closed

6 tasks

rayane-djouah mentioned this pull request Jun 5, 2024

[HOLD for payment 2024-06-06] [$500] Empty state image has too much overlap with message in attachment thread #36166

Closed

6 tasks

hurali97 mentioned this pull request Jul 12, 2024

fix: archived reports are unable to mark as read #45240

Merged

50 tasks

rushatgabhane reviewed Aug 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement get all ancestor of the thread #34640

Implement get all ancestor of the thread #34640

dukenv0307 commented Jan 17, 2024 •

edited

Loading

melvin-bot bot commented Jan 17, 2024

mollfpr commented Jan 19, 2024

mollfpr Jan 19, 2024

dukenv0307 Jan 22, 2024

mollfpr Jan 22, 2024

dukenv0307 commented Jan 22, 2024

mollfpr commented Jan 24, 2024

dukenv0307 commented Jan 24, 2024

dukenv0307 commented Jan 25, 2024

mollfpr left a comment

dukenv0307 commented Jan 26, 2024

mollfpr commented Jan 26, 2024

mollfpr commented Jan 26, 2024

dukenv0307 commented Jan 26, 2024

mollfpr left a comment

mollfpr Jan 29, 2024

dukenv0307 Jan 29, 2024

mollfpr commented Jan 29, 2024 •

edited

Loading

marcaaron commented Feb 1, 2024

marcaaron commented Feb 1, 2024

dukenv0307 commented Feb 2, 2024

mollfpr left a comment

marcaaron left a comment

OSBotify commented Feb 2, 2024

OSBotify commented Feb 5, 2024

OSBotify commented Feb 5, 2024

lanitochka17 commented Feb 6, 2024

Julesssss commented Feb 7, 2024 •

edited

Loading

OSBotify commented Feb 7, 2024

s77rt Apr 26, 2024

marcaaron Apr 26, 2024

roryabraham Apr 28, 2024

rushatgabhane Aug 21, 2024

Implement get all ancestor of the thread #34640

Implement get all ancestor of the thread #34640

Conversation

dukenv0307 commented Jan 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 17, 2024

mollfpr commented Jan 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 commented Jan 22, 2024

mollfpr commented Jan 24, 2024

dukenv0307 commented Jan 24, 2024

dukenv0307 commented Jan 25, 2024

mollfpr left a comment

Choose a reason for hiding this comment

dukenv0307 commented Jan 26, 2024

mollfpr commented Jan 26, 2024

mollfpr commented Jan 26, 2024

dukenv0307 commented Jan 26, 2024

mollfpr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mollfpr commented Jan 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron commented Feb 1, 2024

marcaaron commented Feb 1, 2024

dukenv0307 commented Feb 2, 2024

mollfpr left a comment

Choose a reason for hiding this comment

Updated test recordings

Screenshots/Videos

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 2, 2024

OSBotify commented Feb 5, 2024

OSBotify commented Feb 5, 2024

lanitochka17 commented Feb 6, 2024

Julesssss commented Feb 7, 2024 • edited Loading

OSBotify commented Feb 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 commented Jan 17, 2024 •

edited

Loading

mollfpr commented Jan 29, 2024 •

edited

Loading

Julesssss commented Feb 7, 2024 •

edited

Loading