[HOLD for payment 2024-03-26] [HOLD on E/E #347391][$500] [HIGH] for Collect: Show "Unapprove" report action in NewDot

[Beamanator]

Related to https://github.com/Expensify/Expensify/issues/364085

Flow:

Pre-testing steps

1. Create a new collect policy on OldDot and;
   1. Enable scheduled submit with a frequency of Instant (this should happen by default with Expensify accounts, or accounts on paidPolicyInstantSubmit beta)
   2. Make sure the approval mode is "Submit & Approve"
   3. Invite an additional user to the policy to play the member role in these testing flows
2. Run the following script in the chrome console (in OldDot, when the workspace Settings page is open) to enable the policy for workspace creation for a paid plan.

   p = Policy.getCurrent();
   p.policy.isPolicyExpenseChatEnabled = "true";
   p.save();
   

Test steps

1. In OldDot: As submitter, make sure ^ new workspace is your "Active" / default workspace
2. In OldDot: As submitter, create a report and add an expense
3. In OldDot: As Admin, approve the report - then Unapprove the report
4. In NewDot: As both accounts, view the expense report & verify you can see both of these report actions:
   1. <admin> final approved this report
   2. <admin> unapproved this report

Currently we're blocked on 4 ^ - the <admin> unapproved this report report action does not appear, even though the report action exists in Onyx

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cccf392c943b52d
• Upwork Job ID: 1755224934075211776
• Last Price Increase: 2024-02-07

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cccf392c943b52d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[Beamanator]

Getting some feedback in slack first - internal channel - https://expensify.slack.com/archives/C02NZ2HGJAZ/p1707314650284219

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The UNAPPROVED action is not currently shown in the collect workspace in NEWDOT when an APPROVED report is unapproved.

What is the root cause of that problem?

Here we filter the type of actions that needs to be displayed. Currently, we only include APPROVED and SUBMITTED. Since we have not included UNAPPROVED action, this is not displayed.

What changes do you think we should make in order to solve the problem?

We can solve this problem by adding another constant here for UNAPPROVED and update the line here like this to include UNAPPROVED action.

const isApprovedOrSubmittedReportAction = [CONST.REPORT.ACTIONS.TYPE.UNAPPROVED, CONST.REPORT.ACTIONS.TYPE.APPROVED, CONST.REPORT.ACTIONS.TYPE.SUBMITTED].some((type) => type === action.actionName);

We may also want to change the usage of variable isApprovedOrSubmittedReportAction to something more generic than specific.

What alternative solutions did you explore? (Optional)

[Beamanator]

So far I like this plan ^ but I'm also waiting on a few internal discussions to wrap up before we move forward here

[Beamanator]

(Removing Help Wanted while we wait - sorry this is taking a while)

[Beamanator]

still waiting

[Beamanator]

Hey @twisterdotcom , any chance you could take a look at this one today? 🙏

[Beamanator]

Oh now I see this is on hold for a wave8 issue - maybe we should update the project & make this a Weekly?

[twisterdotcom]

Yup, sorry, we had those discussions and currently landed on the solution in the PR which is slightly different. I was trying to do this myself, but I reached out to a C+ for some help finishing it off.

[eh2077]

@twisterdotcom I followed the test steps #36023 (comment) but it seems my account has to be added into paidPolicyInstantSubmit beta to be able to approve or unapprove the expense instantly. Can you help to add my account ericwdev001+0311@gmail.com to the beta feature?

[twisterdotcom]

Nice, added you! Might take up to an hour to show.

[hoangzinh]

@twisterdotcom could you help to add me toiyeucuocsong99+ws@gmail.com to beta access as well? Thanks.

[twisterdotcom]

Done! Again, could take an hour to show.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show historical OldDot Report Actions in Plain text #38013

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @eh2077 requires payment (Needs manual offer from BZ)

[twisterdotcom]

Payment Summary:

• @hoangzinh paid $500 here (C+)
• @eh2077 paid $500 here (Contributor)

[eh2077]

@twisterdotcom I accepted the offer. Can you help to approve the payment please? Thanks.