Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Workspace - Workspace name character limit is 80 instead of 100 #36352

Closed
6 tasks done
lanitochka17 opened this issue Feb 12, 2024 · 11 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .4.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33601

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings
  3. Select a workspace
  4. Go to Profile > Name
  5. Enter text more than 100 words

Expected Result:

The workspace name character limit is 100

Actual Result:

The workspace name character limit is 80 instead of 100

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376871_1707756722113.20240212_223527__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016db8b2a4859b7008
  • Upwork Job ID: 1757089411969716224
  • Last Price Increase: 2024-02-12
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 12, 2024
@melvin-bot melvin-bot bot changed the title Workspace - Workspace name character limit is 80 instead of 100 [$500] Workspace - Workspace name character limit is 80 instead of 100 Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~016db8b2a4859b7008

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave5
CC @dylanexpensify

@abzokhattab
Copy link
Contributor

abzokhattab commented Feb 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name character limit is 80 instead of 100

What is the root cause of that problem?

here we use 80 instead of 100

App/src/CONST.ts

Line 1574 in 4ff5792

WORKSPACE_NAME_CHARACTER_LIMIT: 80,

What changes do you think we should make in order to solve the problem?

change it to 100

@allgandalf
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name character limit is 80 instead of 100

What is the root cause of that problem?

we have set the length to 80

App/src/CONST.ts

Line 1574 in 4ff5792

WORKSPACE_NAME_CHARACTER_LIMIT: 80,

What changes do you think we should make in order to solve the problem?

set it to 100

What alternative solutions did you explore? (Optional)

N/A

@allgandalf
Copy link
Contributor

Note

@abzokhattab first pointed to the below location and later edited it after my proposal was posted:

App/src/CONST.ts

Line 1574 in 30f8e5d

// The next two constants control what is min and max value of the image crop scale.

Screenshot from 2024-02-12 22-43-40

@ghost
Copy link

ghost commented Feb 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace name character limit is 80 instead of 100

What is the root cause of that problem?

It is set to WORKSPACE_NAME_CHARACTER_LIMIT: 80

App/src/CONST.ts

Line 1574 in 4ff5792

WORKSPACE_NAME_CHARACTER_LIMIT: 80,

What changes do you think we should make in order to solve the problem?

set the WORKSPACE_NAME_CHARACTER_LIMIT: 100

Working Image

Before
CCD8AE98-01AF-47F5-BE56-49855CE87FE4 copy

After
81CC0CF1-C276-4825-BBBD-4B162EB15CB0 copy

@abzokhattab
Copy link
Contributor

@GandalfGwaihir the blob ID in the URL was somehow an old one .. if you can notice I didn't change the referenced line in both edits--> L1574

Thanks

@ghost
Copy link

ghost commented Feb 12, 2024

Update Proposal

@youssef-lr
Copy link
Contributor

youssef-lr commented Feb 12, 2024

This should be fixed as part of this. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants