[HOLD for payment 2024-03-04] [$250] [MEDIUM] Bank account - "PO boxes and mail drop addresses are not allowed" appears twice in Address

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings from the bottom
3. Go to any workspace > Bank account
4. Click Connect manually
5. Proceed until Business info - Company's address

Expected Result:

"PO boxes and mail drop addresses are not allowed" will only appear once

Actual Result:

"PO boxes and mail drop addresses are not allowed" appears twice

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b8183bbc1eecc39
• Upwork Job ID: 1757780866863529984
• Last Price Increase: 2024-02-14
• Automatic offers:
• akinwale | Contributor | 0
• codinggeek2023 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017b8183bbc1eecc39

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[mountiny]

@shubham1206agra @akinwale @MrMuzyk @Swor71 minor design issue

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - "PO boxes and mail drop addresses are not allowed" appears twice in Address

What is the root cause of that problem?

We render the noPO warning twice, once here and then again as a hint to textbox here

What changes do you think we should make in order to solve the problem?

We should remove the warning from top of page here:

App/src/pages/ReimbursementAccount/BusinessInfo/substeps/AddressBusiness.tsx

Line 80 in 2e3840f

<Text>{translate('common.noPO')}</Text>

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"PO boxes and mail drop addresses are not allowed" appears twice in Address

What is the root cause of that problem?

We have noPO at two places here & here.

What changes do you think we should make in order to solve the problem?

We should remove hint from inputWrapper:

App/src/pages/ReimbursementAccount/AddressForm.js

Line 110 in 2e3840f

hint="common.noPO"

What alternative solutions did you explore? (Optional)

N/A

[akinwale]

Based on the new BA flow design doc, the message at the top of the page is a part of the design, so we can remove the hint instead. In this case, @codinggeek2023's suggested approach in their proposal is the way to go.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

I am good to handle this Robert, sorry for the melvin ping

[melvin-bot]

📣 @codinggeek2023 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[eucool]

This also was deployed to production yesterday, did the automation fail @mountiny 🤔

[eucool]

Payment overdue @mountiny :)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

Summary: $250 to @codinggeek2023 please

[joekaufmanexpensify]

@mountiny I assume @akinwale is due payment here too? I see they were automatically sent an offer for this job too.

[shubham1206agra]

@joekaufmanexpensify This is a regression from the VBBA refactor on which @akinwale is C+.

[joekaufmanexpensify]

Ah, got it. Thanks for confirming!

[joekaufmanexpensify]

@codinggeek2023 $250 sent and contract ended!

[joekaufmanexpensify]

@akinwale since this is a regression, I ended the contract without payment.

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!