[HOLD for payment 2024-03-05] [$250] [MEDIUM] Bank account - "Company type" appears twice in the selection list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.41-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings from the bottom.
3. Click any workspace.
4. Click Bank account.
5. Click Connect manually.
6. Proceed until Business info - Company type.
7. Click Company type.

Expected Result:

"Company type" will appear once, which is on the header.

Actual Result:

"Company type" appears twice. One on the header, another one above the list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016a67b6ce58da61a3
• Upwork Job ID: 1757782503971684352
• Last Price Increase: 2024-02-14
• Automatic offers:
• akinwale | Reviewer | 0
• codinggeek2023 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016a67b6ce58da61a3

[melvin-bot]

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

[mountiny]

Minor design issue

[melvin-bot]

Upwork job price has been updated to $250

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - "Company type" appears twice in the selection list

What is the root cause of that problem?

We have headerMessage defined in SelectionList:

What changes do you think we should make in order to solve the problem?

Remove the headerMessage from SelectionList:

App/src/pages/ReimbursementAccount/BusinessInfo/substeps/TypeBusiness/BusinessTypePicker/BusinessTypeSelectorModal.tsx

Line 64 in 2e3840f

headerMessage={translate('businessInfoStep.companyType')}

What alternative solutions did you explore? (Optional)

N/A

[akinwale]

@codinggeek2023's proposal works here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

I am good to handle this, sorry for the ping Tyler

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @codinggeek2023 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[eucool]

This was deployed to production yesterday, did the automation fail @mountiny 🤔

[mountiny]

Payment for @akinwale will be handled here #22901 (comment)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[puneetlath]

I've paid @codinggeek2023.

I did not pay @akinwale because of this comment: #36504 (comment). I ended the Upwork contract for him without paying.

Thanks everyone!