[HOLD for payment 2024-03-07] [$500] VBA - Background page is "reloading" when proceeding through VBA flow

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Access a Workspace settings page
4. Go to "Connect bank account" and follow the flow
5. Observe the background flow as you proceed through the steps

Expected Result:

The user expects the background to be unchanged, only the side modal should display loading icons

Actual Result:

The background is constantly reloaded as well at the side modal, making it "two loading" screens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379415_1707919378829.Background_is_reloading_when_proceeding_through_VBA.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015afe16eee041d143
• Upwork Job ID: 1757788005606686720
• Last Price Increase: 2024-02-21
• Automatic offers:
• alitoshmatov | Reviewer | 0
• rayane-djouah | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015afe16eee041d143

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[saif-o99]

i wish i could run this project so i can contribute...

[melvin-bot]

📣 @saif-o99! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lschurr]

Waiting on proposals.

[wlegolas]

Hi @lschurr and @lanitochka17 do you have a bank test information to share to test this issue?

I tried to test using some fake back information, but the second step validated the information.

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Background page is "reloading" when proceeding through VBA flow.

What is the root cause of that problem?

when we setup the bank account in the right modal we are showing ReimbursementAccountLoadingIndicator here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 436 to 438 in 6f3d8f6

	if ((!hasACHDataBeenLoaded || isLoading) && shouldShowOfflineLoader && (shouldReopenOnfido || !requestorStepRef.current)) {
	return <ReimbursementAccountLoadingIndicator onBackButtonPress={goBack} />;
	}

when the reimbursement account is loading from the server:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 418 in 6f3d8f6

const isLoading = (isLoadingApp || account.isLoading || reimbursementAccount.isLoading) && (!plaidCurrentEvent || plaidCurrentEvent === CONST.BANK_ACCOUNT.PLAID.EVENTS_NAME.EXIT);

and in the background we have a WorkspacePageWithSections, we are showing also a FullScreenLoadingIndicator

App/src/pages/workspace/WorkspacePageWithSections.tsx

Lines 169 to 171 in 6f3d8f6

	{(isLoading || firstRender.current) && shouldShowLoading ? (
	<FullScreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
	) : (

when the reimbursement account is loading from the server:

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 112 in 6f3d8f6

const isLoading = reimbursementAccount?.isLoading ?? true;

this is why both background page and the right modal are showing loading views.

What changes do you think we should make in order to solve the problem?

we should change the condition in WorkspacePageWithSections to show the FullScreenLoadingIndicator only when the component is focused:

import {useIsFocused} from '@react-navigation/native';

const isFocused = useIsFocused();

  {(isLoading || firstRender.current) && shouldShowLoading && isFocused ? (
      <FullScreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
  ) : (

this way, when we are focusing on the right modal and the account is loading from the server, the background will be unchanged, and only the right side modal display a loading view.

Result

Before:

before.Recording.2024-02-18.204009.mp4

After:

after.Recording.2024-02-18.203850.mp4

What alternative solutions did you explore? (Optional)

N/A

[lschurr]

Could you review this one @alitoshmatov?

[lanitochka17]

@wlegolas Hello
Fully verified bank account credentials
Use Regions bank
Username: user_good | Password: pass_good
Account type: Plaid Saving (2nd option)
CompanyName: Alberta Bobbeth Charleson
CompanyTaxID: 123456789
First Name: Alberta
Last Name: Charleson
Last SSN numbers: 3333

Fill the rest of the fields with random data.

[alitoshmatov]

@rayane-djouah Can you make sure there are no cases where WorkspacePageWithSections is shown unexpectedly without loading?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rayane-djouah]

@alitoshmatov I tested my proposal and didn't find such case. WorkspacePageWithSections is loading correctly when focused 👍

[wlegolas]

user_good

Hi @lanitochka17 I tried to use this information but didn't work locally and on staging.

Do you have another account?

[alitoshmatov]

I think we can go with @rayane-djouah 's proposal. It has correct RCA and uses focus to determine to show loading or not

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lanitochka17]

I am not able to reproduce this issue with build 1.4.43-19

Recording.1295.mp4

@wlegolas Hello

• try adding this data:
  Phone number: 5082211111
  Birthday 01-01-1980
  Incorporation day: 01-01-2010

[rayane-djouah]

@lanitochka17 I'm still able to reproduce it on staging. you need to start the new bank account flow from a workspace settings page other than "Profile" or "Members" (example: "Cards")

vba.Recording.2024-02-27.122258.mp4

[rayane-djouah]

@alitoshmatov PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: VBA - Background page is reloading when proceeding through VBA flow #37188

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@alitoshmatov Could you work through the checklist on this one?

[rayane-djouah]

@lschurr Friendly reminder for payment, Thank you!

[lschurr]

Payment summary:

• Contributor: @rayane-djouah $500
• Contributor+: @alitoshmatov $500

[lschurr]

Bumped in Slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1709841698280919

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: Display loading page for workspace page with section #32903
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32903/files#r1518264997
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug. No need

[cristipaval]

Is this paid? Shall we close the issue?

[alitoshmatov]

Payment is done(at least on my part)

[lschurr]

Yep, all set! Closing.