Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] [Splits] Show Split bill in global create, separate out the split and request flows #36748

Closed
kevinksullivan opened this issue Feb 16, 2024 · 43 comments
Assignees
Labels
Design NewFeature Something to build that is a new item. Planning Changes still in the thought process Weekly KSv2

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Feb 16, 2024

DESIGN DOC

Problem

As it's been discussed in this thread and elsewhere, our approach to merging both split and request into a single flow is very confusing, for a few reasons:

  1. It makes seem like you have to split a request with someone, when in reality the more common flow is requesting money from one person
  2. It's not clear that there is a path to requesting "normally", which can be done by tapping the row outside of the split button. This means each row has two very different possible actions, but only one is visible in the UI

We've had 10+ people at our company mention this as a point of confusion when requesting money from friends or while testing the Collect experience as a member requesting repayment from a workspace.

Solution

Let's address this problem by:

  1. Bringing back a dedicated Split bill option within global create, under the Request money option. This will help us differentiate between the flows, and promote a use case we want users to be aware of.
image
  1. Removing the "split" button from the request money flow

Outstanding considerations

Going to jot down a few thoughts on this one here, just so I have it written down.

How should the split bill flow work for making a single selection v. multi-selection?

image

We have a few options that I can think of, and likely many others:

  1. Making any selection go straight to the 1:1 confirmation screen, and then showing a + icon on the confirmation screen, as shown here).
  2. Keep it similar today, where the button says something like Add to split for split, and and tapping that option supports multi-select, or tapping outside of the button goes straight to the 1:1 confirmation screen (doesn't address the problem of one row two actions)
  3. Anytime a user makes a selection, showing Continue, before landing them on the confirmation screen, making it clear you can select multiple users. This makes the 1:1 split flow less efficient, but I think that is going to be a pretty rare flow if we have a dedicated request flow.

Should the Request money flow allow for adding multiple people to a request?

Today we don't allow requesting money from multiple people at once. It has to go through the split flow. So, do we want to change that? I'm on the fence. I've long used venmo to send requests to a bunch of people at once. But now, they've essentially baked that into a split flow, and I can see a pretty clear case for not needing it at all.

### Implementation

Implementation issues created, will be implemented in the following order:

  1. External [vip-split] [Split Expense] Cleanup all instances of "request" and "send money" in App #40070 @shubham1206agra @getusha
  2. External [vip-split] [Split Expense] Refactor Participant Selector #40071 @getusha @shubham1206agra
  3. Internal [vip-split] [Split Expense] Update copy changes in backend #40072 @mountiny
  4. External [vip-split] [Split Expense] Implement route changes in NewDot for updated Global Create #40073 @shubham1206agra @getusha
  5. External [vip-split] [Split Expense] Clean up instances of request terminology in HelpDot #40074 @shubham1206agra @getusha
  6. Internal [vip-split] [Split Expense] Clean up the money request terminology in app to use expense #40075 @mountiny
@kevinksullivan kevinksullivan added Daily KSv2 Planning Changes still in the thought process NewFeature Something to build that is a new item. Design labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

Copy link

melvin-bot bot commented Feb 16, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 16, 2024
@kevinksullivan
Copy link
Contributor Author

posted this ^ as a quick pre-design

@Krishna2323

This comment was marked as resolved.

@shawnborton
Copy link
Contributor

@kevinksullivan let me know when and where I can help with this. Maybe we just need to see how the pre-design settles first and then we can create final mocks from there?

@arielgreen arielgreen changed the title Show Split bill in global create, separate out the split and request flows [CRITICAL] [Split] Show Split bill in global create, separate out the split and request flows Feb 20, 2024
@arielgreen arielgreen changed the title [CRITICAL] [Split] Show Split bill in global create, separate out the split and request flows [CRITICAL] [Splits] Show Split bill in global create, separate out the split and request flows Feb 20, 2024
@kevinksullivan kevinksullivan self-assigned this Feb 21, 2024
@kevinksullivan
Copy link
Contributor Author

pre-design went out here. Next step I think we follow up with an option that show's option 3 from the pre-design in more detail than I presented it, then we can explore a mini-doc or just GH it. @shawnborton what do you think?

@shawnborton
Copy link
Contributor

Posted some ideas for ya here.

@kevinksullivan
Copy link
Contributor Author

Working on the doc

@kevinksullivan kevinksullivan added the DesignDocReview Autoassigner for design doc reviews label Feb 28, 2024
@MonilBhavsar
Copy link
Contributor

I have read and reviewed this Design Doc!

7 similar comments
@isabelastisser
Copy link
Contributor

I have read and reviewed this Design Doc!

@nkuoch
Copy link
Contributor

nkuoch commented Apr 9, 2024

I have read and reviewed this Design Doc!

@trjExpensify
Copy link
Contributor

I have read and reviewed this Design Doc!

@jliexpensify
Copy link
Contributor

I have read and reviewed this Design Doc!

@amyevans
Copy link
Contributor

I have read and reviewed this Design Doc!

@quinthar
Copy link
Contributor

I have read and reviewed this Design Doc!

@JmillsExpensify
Copy link

I have read and reviewed this Design Doc!

@shubham1206agra
Copy link
Contributor

@mountiny The order of 1 and 2 is wrong. We will do 2 first.

@pecanoro
Copy link
Contributor

I have read and reviewed this Design Doc!

@getusha
Copy link
Contributor

getusha commented Apr 11, 2024

@mountiny The order of 1 and 2 is wrong. We will do 2 first.

@shubham1206agra the current order makes sense to me 🤔

@shubham1206agra
Copy link
Contributor

@getusha See design doc.

@grgia
Copy link
Contributor

grgia commented Apr 12, 2024

I have read and reviewed this Design Doc!

@mountiny
Copy link
Contributor

Daily updates in the vip-split room. We are chugging along well to meet the Release 1 deadline

@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@shawnborton
Copy link
Contributor

I see this one is implemented in the product already, right?

@kevinksullivan
Copy link
Contributor Author

Yes, this is live! I'd say we can close this out. @mountiny lmk if you think differently!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design NewFeature Something to build that is a new item. Planning Changes still in the thought process Weekly KSv2
Projects
None yet
Development

No branches or pull requests