[HOLD for payment 2024-08-05] Include build artifacts on GH releases for all deploys

[roryabraham]

Problem

Sometimes, such as for upgrades, or when searching for the source of a regression, we want to test a old version(s) of our app, but we currently don't provide an easy way to do that.

Solution (part 1)

Include build artifacts on all our GitHub releases:

• The .dmg for the desktop app
• The APK for the Android app
• The AAP for the iOS app

source code is already included.

Solution (part 2)

Currently our deploy paradigm is:

- 1 tag == 1 staging deploy
- 1 release == 1 production deploy

We should update it such that it's:

- 1 prerelease == 1 staging deploy
- 1 release == 1 production deploy

That way we have historical artifacts from all our deploys, not just production deploys.

Issue Owner

Current Issue Owner: @mallenexpensify

[roryabraham]

Pretty low priority, but also should be pretty easy (part 1, anyways). Saving this for a rainy day

[roryabraham]

Two things are on HOLD for this, so I'm going to bump the priority and try to get it out sometime this week.

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[roryabraham]

this isn't a product feature but a development/QA testing feature

[mallenexpensify]

@roryabraham let me know if I can help 'spread the word' when this is done. ie. SO, post/pin in #expensify-open-source.

[roryabraham]

yeah, that'd be helpful

[roryabraham]

co-assigning you here but making myself the issue owner for the time being

[mallenexpensify]

Not a high priority, Rory will get to soon (curious if my commenting will remove overdue if you're the owner Rory)

[roryabraham]

prioritizing a few other things over this

[mallenexpensify]

@roryabraham I removed NewFeature and added Improvement because we're moving all bugs and feature requests to projects and I couldn't think of where this would best fit on our roadmap

[mallenexpensify]

Rory has to comment for it to not be overdue

[roryabraham]

Yeah, I'm not sure where this fits in the roadmap, but I do think it's an important improvement that will allow us to better test and monitor the app upgrade process

[melvin-bot]

This issue has not been updated in over 15 days. @mallenexpensify, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[roryabraham]

Put up a PR for part 1: #45364

[roryabraham]

First part is done, and I'm actually going to call this done-done. We will now be able get the release artifacts for every deploy (after one more full deploy cycle happens).

To get release artifacts for production deploys, just go to https://github.com/Expensify/App/releases, find the release you want, and look at Assets.

To get release artifacts for staging deploys, go to https://github.com/Expensify/App/actions/workflows/platformDeploy.yml, click on the workflow run for the version you're looking for, and the release artifacts will be there at the bottom.

It's worth noting that release artifacts for staging deploys won't be stored forever, but AFAIK release artifacts for production deploys will be. I think that's probably fine, and fixing it by completing the 2nd half of this issue would be an order of magnitude harder than completing the first half was.

[mallenexpensify]

oooh, neat! I created this SO and asked ya. Seems like something we want documented and I wasn't able to find anything when I searched. Can you also share deets in #expensify-open-source and pin the post? (or... I'll do so once you've updated the SO).

[roryabraham]

answered in SO

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Upload web release assets #46216

If no regressions arise, payment will be issued on 2024-08-05. 🎊