[No QA] Release artifacts for every deploy #45364

roryabraham · 2024-07-13T01:28:05Z

Details

Part 1 of this issue. This PR ensures that:

desktop build artifacts (NewExpensify.dmg) are uploaded for every deploy (currently we archive no desktop release assets at all)
for production deploys, build artifacts are uploaded to the GitHub Release such that they'll be stored long-term and be easier to find
no build artifacts are uploaded for web builds, because it's essentially just more source code, which GitHub automatically archives with releases. I couldn't think of any valuable reason to upload the dist/ folder 🤷🏼
Also DRY'd things up a bit in a few places

Fixed Issues

$ (partial) #36758

Tests

The main thing I tested locally was the gh cli stuff:

gh run list --workflow platformDeploy.yml --event push --branch 9.0.5-13 --json databaseId --jq '.[0].databaseId'

After this is merged, we should:

look at staging deploys and verify that the artifacts are uploaded to the workflow run
look at production release and verify that the artifacts are uploaded to the GitHub release
Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

None.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-13T01:28:32Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-07-13T01:38:54Z

@francoisl @Julesssss tagged you in for review since you're app deployers and likely more familiar with this workflow than @aldo-expensify.

Julesssss

Nothing jumps out to me in these changes. But I think we should hold on this PR, as at least 50% of the builds are currently failing.

# Conflicts: # .github/workflows/platformDeploy.yml

Julesssss · 2024-07-15T17:05:32Z

Nothing jumps out to me in these changes. But I think we should hold on this PR, as at least 50% of the builds are currently failing.

This is clear now. Fixes were CP'd today.

francoisl

LGTM, small questions

.github/workflows/platformDeploy.yml

francoisl · 2024-07-15T17:30:32Z

.github/workflows/platformDeploy.yml

-        if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
-        run: /home/runner/.local/bin/cli4 --verbose --delete hosts=["staging.new.expensify.com"] /zones/:9ee042e6cfc7fd45e74aa7d2f78d617b/purge_cache
+      - name: Purge Cloudflare cache
+        run: /home/runner/.local/bin/cli4 --verbose --delete hosts=["${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && '' || 'staging.' }}new.expensify.com"] /zones/:9ee042e6cfc7fd45e74aa7d2f78d617b/purge_cache


Is the zone ID 9ee042e6cfc7fd45e74aa7d2f78d617b the same for prod and staging? Not sure how to check where it comes from, but I imagine somewhere in our Cloudflare account.

Pretty sure it's the same - it is currently used for purging the cloudflare cache on both prod and staging on main now. This PR just DRYs things up

# Conflicts: # .github/workflows/platformDeploy.yml

roryabraham · 2024-07-16T20:16:10Z

Got tests passing (it was a pain, and I created #45413 to try and make things easier in the future, but it's not particularly high priority).

anyways, this is ready for review!

francoisl · 2024-07-16T21:32:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aldo-expensify · 2024-07-16T22:25:19Z

more familiar with this workflow than @aldo-expensify.

1000% ❤️

roryabraham · 2024-07-16T22:29:06Z

Merging since @Julesssss already approved and I only changed tests.

OSBotify · 2024-07-16T22:40:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:41Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T15:50:01Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:54:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T19:37:19Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 9 commits July 12, 2024 17:09

Upgrade upload-artifact to v4

c1e354b

Upload artifacts for desktop build

abd7410

DRY up web deploy workflow

4a1d0dc

Upload artifacts to GitHub release

38ae9a7

DRY up Android fastlane step

f42cde1

Download the build artifact and upload it in a release

2012c8c

DRY iOS Fastlane step

35c5950

Download the iOS build artifact and upload it in a release

75b594a

Build not version

df52878

roryabraham self-assigned this Jul 13, 2024

roryabraham requested a review from a team as a code owner July 13, 2024 01:28

melvin-bot bot requested review from aldo-expensify and removed request for a team July 13, 2024 01:28

roryabraham mentioned this pull request Jul 13, 2024

[HOLD for payment 2024-08-05] Include build artifacts on GH releases for all deploys #36758

Closed

roryabraham added 3 commits July 12, 2024 18:32

Don't use env context at job level if

f7a6f58

Remove unnecessary change

aae158d

Use fromJSON instead of == true

e5eb7fc

roryabraham requested a review from francoisl July 13, 2024 01:37

roryabraham requested a review from Julesssss July 13, 2024 01:39

Fix android archive name for gh run download

5f49be3

Julesssss reviewed Jul 15, 2024

View reviewed changes

Merge branch 'main' into Rory-ReleaseArtifactsForEveryDeploy

0fc534e

# Conflicts: # .github/workflows/platformDeploy.yml

roryabraham requested a review from Julesssss July 15, 2024 16:30

roryabraham mentioned this pull request Jul 15, 2024

[$500] Desktop deploys always give a "false negative" #35629

Closed

6 tasks

Julesssss previously approved these changes Jul 15, 2024

View reviewed changes

Upgrade @kie/act-js

98c532e

francoisl reviewed Jul 15, 2024

View reviewed changes

roryabraham added 2 commits July 15, 2024 10:51

Update platformDeploy mocks

ee40985

Fix more mocks and assertions

96a51bb

roryabraham dismissed Julesssss’s stale review via 96a51bb July 15, 2024 19:41

roryabraham added 8 commits July 15, 2024 12:49

fix desktop build step mock

3c605d0

Test exit status code

3999ecd

Revert test code

1982a53

Merge branch 'main' into Rory-ReleaseArtifactsForEveryDeploy

90325e0

# Conflicts: # .github/workflows/platformDeploy.yml

Add upload step assertions for desktop job

3d9faef

Add tests for Android job

88f6b6b

Add tests for iOS job

9bd45cb

Remove unused param

449fbfe

roryabraham requested review from francoisl and Julesssss July 16, 2024 20:11

francoisl approved these changes Jul 16, 2024

View reviewed changes

roryabraham merged commit 45ae2dd into main Jul 16, 2024
18 of 19 checks passed

roryabraham deleted the Rory-ReleaseArtifactsForEveryDeploy branch July 16, 2024 22:29

github-actions bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

roryabraham mentioned this pull request Jul 24, 2024

[No QA] Fix prod web deploys #46152

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Release artifacts for every deploy #45364

[No QA] Release artifacts for every deploy #45364

roryabraham commented Jul 13, 2024

melvin-bot bot commented Jul 13, 2024

roryabraham commented Jul 13, 2024 •

edited

Loading

Julesssss left a comment

Julesssss commented Jul 15, 2024

francoisl left a comment

francoisl Jul 15, 2024

roryabraham Jul 16, 2024

roryabraham commented Jul 16, 2024 •

edited

Loading

francoisl commented Jul 16, 2024

aldo-expensify commented Jul 16, 2024

roryabraham commented Jul 16, 2024

OSBotify commented Jul 16, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

[No QA] Release artifacts for every deploy #45364

[No QA] Release artifacts for every deploy #45364

Conversation

roryabraham commented Jul 13, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 13, 2024

roryabraham commented Jul 13, 2024 • edited Loading

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss commented Jul 15, 2024

francoisl left a comment

Choose a reason for hiding this comment

francoisl Jul 15, 2024

Choose a reason for hiding this comment

roryabraham Jul 16, 2024

Choose a reason for hiding this comment

roryabraham commented Jul 16, 2024 • edited Loading

francoisl commented Jul 16, 2024

Reviewer Checklist

Screenshots/Videos

aldo-expensify commented Jul 16, 2024

roryabraham commented Jul 16, 2024

OSBotify commented Jul 16, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

roryabraham commented Jul 13, 2024 •

edited

Loading

roryabraham commented Jul 16, 2024 •

edited

Loading