-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment due March 7] [Performance] Remove cache from the getOrderedReportIDs method #36799
Comments
Hi @mountiny |
@mountiny, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Merged |
@mountiny, @kacper-mikolajczak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@mountiny, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I am due payment for the PR review on this. Deployed to production last week so should be due payment today, I think. 🙇 |
Triggered auto assignment to @Christinadobrzyn ( |
Payouts due: Contributor+: $500 @jjcoffee (in Upwork - offer sent - https://www.upwork.com/nx/wm/offer/101274490 Upwork job is here. sent you an offer @jjcoffee! |
@Christinadobrzyn Accepted, thanks! 🙇 |
Awesome! Paid to you @jjcoffee based on this payment summary #36799 (comment) Closing |
Coming from Slack
Problem
Whenever we want to calculate order of reports in the LHN, the
getOrderedReportIDs
function is called. Based on our investigations for different metrics (Report load time and Send a message), we can tell that thegetOrderedReportIDs
is a main bottleneck responsible for app's degrading performance.Details can be found in the Cache part of this analysis
### Solution
In order to fix the underlying issue, we have splitted the implementation into a few atomic PRs that could be easily digested. One of them is presented below.
Followed the analysis, the overhead that stems from cache lookup when generating ordered reports does not match its possible positive outcomes on overall time execution. Analysis, as well as, measurements with possible gains of removing the cache are presented in linked issues.
The text was updated successfully, but these errors were encountered: