Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#36948][$500] Windows - Settings - The textbox isn't auto focused #37410

Closed
1 of 6 tasks
izarutskaya opened this issue Feb 28, 2024 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when executing PR : #34925

Version Number: 1.4.44.0
Reproducible in staging?: Y
Reproducible in production?: N, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

  1. Navigate to Settings - Switch to Expensify Classic
  2. Choose any option
  3. Click on the Next button

Expected Result:

It should be focused and the keyboard should be visible.

Actual Result:

The textbox isn't auto focused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Bug6395114_1709099828570.bandicam_2024-02-27_20-13-53-862.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014abe2f898e817726
  • Upwork Job ID: 1762803417818267648
  • Last Price Increase: 2024-02-28
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014abe2f898e817726

@melvin-bot melvin-bot bot changed the title Windows - Settings - The textbox isn't auto focused [$500] Windows - Settings - The textbox isn't auto focused Feb 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

We think that this bug might be related to #wave9-collect-signup
CC @MitchExpensify

@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The textbox isn't auto focused.

What is the root cause of that problem?

We don't have autofocusing behavior in Before you go page

What changes do you think we should make in order to solve the problem?

Add autofocusing behavior in Before you go page (ExitSurveyResponsePage) by using useAutoFocusInput

In here

const {inputCallbackRef} = useAutoFocusInput();

In here or here

inputCallbackRef(el);

The useAutoFocusInput approach (that uses this implementation) is the agreed standardized approach that we should use in this case, and it's currently being used almost everywhere in the app (Example: 1, 2, 3)

What alternative solutions did you explore? (Optional)

NA

@Krishna2323
Copy link
Contributor

Krishna2323 commented Feb 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The textbox isn't auto focused.

What is the root cause of that problem?

We don't pass autoFocus prop to InputWrapper in ExitSurveyResponsePage .

What changes do you think we should make in order to solve the problem?

Pass autoFocus prop to InputWrapper in ExitSurveyResponsePage . Also use shouldDelayFocus along with autoFocus.

Result

@dukenv0307
Copy link
Contributor

Proposal updated to add implementation details

@danieldoglas
Copy link
Contributor

This doesn't need to be a deploy blocker

@danieldoglas danieldoglas added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 28, 2024
@Ollyws
Copy link
Contributor

Ollyws commented Feb 29, 2024

Agree with @dukenv0307's proposal, the useAutoFocusInput hook is the way to go here.
🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Feb 29, 2024

Current assignee @danieldoglas is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@situchan
Copy link
Contributor

This is another instance of useAutoFocusInput issue. It will be handled in #36948 (comment)

@danieldoglas danieldoglas changed the title [$500] Windows - Settings - The textbox isn't auto focused [HOLD App#36948][$500] Windows - Settings - The textbox isn't auto focused Feb 29, 2024
@MitchExpensify
Copy link
Contributor

Are you recommending we close this @situchan ?

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@danieldoglas
Copy link
Contributor

Are you recommending we close this @situchan ?

It will fixed on another issue, but it was not reported on that issue. Though I think since we're fixing all instances, I think it's safe to close.

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@danieldoglas
Copy link
Contributor

Closing in favor of #36948 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants