[HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. #37656

lanitochka17 · 2024-03-02T16:43:08Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.46
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4359738
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-condition: User A in old dot must have a collect workspace

Launch app with user A
As same user login old dot
Set Collect Workspace as default
In new dot, tap fab --- start chat
Tap room
Note the Workspace field

Expected Result:

The Workspace you are currently filtering by should be shown as the top suggested option when creating a room. If filtering by all, your default workspace should be shown as the top suggested option when creating a room.

Actual Result:

Workspace is not shown empty on setting personal Workspace as default

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6399190_1709557892248.changee.mp4

View all open jobs on GitHub

melvin-bot · 2024-03-02T16:43:21Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

lanitochka17 · 2024-03-02T16:43:43Z

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

allgandalf · 2024-03-03T00:31:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS is not shown empty on setting collect WS as default

What is the root cause of that problem?

In useEffect, we set PolicyID to activePolicyID when the any value from workspaceOptions match activePolicyID

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 128 to 140 in 22cb01c

    
           useEffect(() => { 
        
               if (policyID) { 
        
                   if (!workspaceOptions.some((opt) => opt.value === policyID)) { 
        
                       setPolicyID(''); 
        
                   } 
        
                   return; 
        
               } 
        
               if (!!activePolicyID && workspaceOptions.some((opt) => opt.value === activePolicyID)) { 
        
                   setPolicyID(activePolicyID); 
        
               } else { 
        
                   setPolicyID(''); 
        
               } 
        
           }, [activePolicyID, policyID, workspaceOptions]);

And this further sets the default value over here:

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 287 to 294 in 22cb01c

    
           <InputWrapper 
        
               InputComponent={ValuePicker} 
        
               inputID={INPUT_IDS.POLICY_ID} 
        
               label={translate('workspace.common.workspace')} 
        
               items={workspaceOptions} 
        
               value={policyID} 
        
               onValueChange={(value) => setPolicyID(value as typeof policyID)} 
        
           />

What changes do you think we should make in order to solve the problem?

In useEffect as well as useState , we must add one more condition to check for the type of the current option and only set the policy id to the active one if it is not equal to team:

Essentially we would set setPolicyID to empty string in useEffect and return empty string in useState The update would be like:

    const [policyID, setPolicyID] = useState<string>(() => {
        if (!!activePolicyID && workspaceOptions.some((option) => (option.value === activePolicyID && option.type !== CONST.POLICY.TYPE.TEAM))) {
            return activePolicyID;
        }
        return '';
    });
    
    useEffect(() => {
     .....
        if (!!activePolicyID && workspaceOptions.some((opt) => (opt.value === activePolicyID && opt.type !== CONST.POLICY.TYPE.TEAM))) {
            setPolicyID(activePolicyID);
        }

The type property is inherited from workspaceOptions, we will define a new variable as type which is present in policy

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 73 to 83 in 22cb01c

    
           const workspaceOptions = useMemo( 
        
               () => 
        
                   PolicyUtils.getActivePolicies(policies) 
        
                       ?.filter((policy) => policy.type !== CONST.POLICY.TYPE.PERSONAL) 
        
                       .map((policy) => ({ 
        
                           label: policy.name, 
        
                           value: policy.id, 
        
                       })) 
        
                       .sort((a, b) => localeCompare(a.label, b.label)) ?? [], 
        
               [policies], 
        
           );

Result:

simplescreenrecorder-2024-03-03_05.58.41.mp4

MitchExpensify · 2024-03-03T20:56:03Z

I'm not sure why we'd want the Workspace field to show be blank here on the room creation screen. I'd expect us to show the Collect default workspace in the workspace field which seems to be what is happening - Rigth @lanitochka17 ?

Krishna2323 · 2024-03-04T11:01:39Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - WS is not shown empty on setting collect WS as default.

What is the root cause of that problem?

I believe the current behavior is partially correct. When a user has set a default workspace, it should be selected as the default in the room creation flow. However, the issue arises when the user switches to a different workspace in NewDot from the workspace switcher. When the user creates a room, the default workspace remains the default from the OldDot. In my opinion, for better user experience, we should select the newly selected workspace from NewDot.

Bug Video

default_workspace_bug.mp4

What changes do you think we should make in order to solve the problem?

Instead of checking for activePolicyID from OldDot first, we should verify whether the user has selected any workspace from NewDot. If there is no selected workspace in NewDot, we will set the default to activePolicyID from OldDot. We can obtain the active workspace in NewDot using const {activeWorkspaceID} = useActiveWorkspace(). Then, we can use const activeID = activeWorkspaceID ?? activePolicyID; to obtain the default value for policyID.

We will replace activePolicyID with activeID.

Result

default_ws.mp4

Alternative

If we want to always show empty default WS we can remove code blocks below:

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 85 to 87 in 4231ac9

    
           if (!!activePolicyID && workspaceOptions.some((option) => option.value === activePolicyID)) { 
        
               return activePolicyID; 
        
           }

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 135 to 137 in 4231ac9

    
           if (!!activePolicyID && workspaceOptions.some((opt) => opt.value === activePolicyID)) { 
        
               setPolicyID(activePolicyID); 
        
           } else {

Krishna2323 · 2024-03-04T11:03:36Z

@MitchExpensify, can you please provide some feedback on this? Thanks

I believe the current behavior is partially correct. When a user has set a default workspace, it should be selected as the default in the room creation flow. However, the issue arises when the user switches to a different workspace in NewDot from the workspace switcher. When the user creates a room, the default workspace remains the default from the OldDot. In my opinion, for better user experience, we should select the newly selected workspace from NewDot.

Bug Video

default_workspace_bug.mp4

MitchExpensify · 2024-03-06T06:20:49Z

Yeah this is an interesting question @Krishna2323 - Should the workspace you are filtering by in NewDot be shown as the default workspace when creating a room? I think the answer is "yes" and I'll double-check internally that others agree!

Krishna2323 · 2024-03-08T06:38:43Z

@MitchExpensify, any updates?

allgandalf · 2024-03-08T21:16:18Z

Should the workspace you are filtering by in NewDot be shown as the default workspace when creating a room?

@MitchExpensify I think collect workspaces are still not show by default in ND, we need to run a script when we create new collect policy in OD for it to show in ND, so I think not relying on ND workspace is a safe option

(not 100% sure about this, but just thought this out loud :) )

I'm not sure why we'd want the Workspace field to show be blank here on the room creation screen.

We are updating ND to create collect workspaces by default, with this change, we give the user 7 day free trail, when it is over then we don't want the user to create a room with the expired workspace, and hence i think the expected behavior is mentioned in the issue

MitchExpensify · 2024-03-10T22:15:25Z

Double checking what the team thinks!

Krishna2323 · 2024-03-14T01:56:55Z

@MitchExpensify, do we have an update here?

melvin-bot · 2024-03-14T19:18:27Z

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

MitchExpensify · 2024-03-16T18:59:39Z

Yes! The expected behavior is to show the Workspace you are currently filtering by as the suggested Workspace when creating a room. Updated the expected behavior:

Expected Result:

The Workspace you are currently filtering by should be shown as the top suggested option when creating a room. If filtering by all, your default workspace should be shown as the top suggested option when creating a room.

melvin-bot · 2024-03-16T18:59:52Z

Job added to Upwork: https://www.upwork.com/jobs/~014b390ee1a3dc9cad

melvin-bot · 2024-03-16T18:59:57Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

melvin-bot · 2024-03-16T19:01:59Z

@MitchExpensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

hoangzinh · 2024-03-21T11:06:50Z

Thanks @MitchExpensify I will review proposals today

hoangzinh · 2024-03-21T11:51:01Z

Thanks for proposals, everyone. I like @Krishna2323's proposal here. He coordinated with Mitch to come up with the right expectations. He also provided a correct RCA and solution.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-03-21T11:51:14Z

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Krishna2323 · 2024-03-23T11:37:04Z

@hoangzinh, PR ready for review.

melvin-bot · 2024-04-08T10:47:14Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-04-08T10:47:17Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Room - WS is not selected when filtered from newdot. #38861

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment (Needs manual offer from BZ)
@Krishna2323 requires payment (Needs manual offer from BZ)

melvin-bot · 2024-04-08T10:47:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

MitchExpensify · 2024-04-09T03:57:59Z

Payment summary:

C: @Krishna2323 $500 Upwork
C+: @hoangzinh $500 Upwork

MitchExpensify · 2024-04-15T16:28:08Z

Friendly bump on your regression step suggestion @hoangzinh 🙇

Offers sent for payment on this Job https://www.upwork.com/jobs/~014b390ee1a3dc9cad

Krishna2323 · 2024-04-15T16:32:41Z

@MitchExpensify thanks, accepted 😁

melvin-bot · 2024-04-15T18:05:30Z

Payment Summary

Upwork Job

ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)
ROLE: @Krishna2323 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

MitchExpensify · 2024-04-15T20:25:20Z

paid, thanks @Krishna2323 !

hoangzinh · 2024-04-17T10:24:43Z

Regression Test Proposal

Pre-condition: User must have a default workspace and some other workspaces in OldDot

Sign in to New Dot
Tap FAB => Start chat
Select tab Room
Verify the default WS from OldDot is auto-selected in the workspace select box
Close "Start chat" modal
Open the workspace switcher => select any other workspace
Repeat step 2->3
Verify that the workspace selected in step 5 is auto-selected in the workspace select box

Do we agree 👍 or 👎

hoangzinh · 2024-04-17T10:27:09Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: I think there is no PR causing this issue. It's a new requirement/expected result.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes

hoangzinh · 2024-04-19T08:47:54Z

@MitchExpensify could you process payment for me in upwork? Thanks

MitchExpensify · 2024-04-22T16:32:02Z

Done!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 2, 2024

melvin-bot bot assigned MitchExpensify Mar 2, 2024

melvin-bot bot added the Overdue label Mar 8, 2024

melvin-bot bot added Overdue and removed Overdue labels Mar 10, 2024

melvin-bot bot removed the Overdue label Mar 16, 2024

MitchExpensify added Help Wanted Apply this label when an issue is open to proposals by contributors Overdue External Added to denote the issue can be worked on by a contributor labels Mar 16, 2024

melvin-bot bot changed the title ~~Room - WS is not shown empty on setting collect WS as default.~~ [$500] Room - WS is not shown empty on setting collect WS as default. Mar 16, 2024

melvin-bot bot assigned ishpaul777 Mar 16, 2024

melvin-bot bot removed the Overdue label Mar 16, 2024

melvin-bot bot added the Overdue label Mar 18, 2024

melvin-bot bot assigned AndrewGable Mar 21, 2024

AndrewGable assigned Krishna2323 Mar 21, 2024

Krishna2323 mentioned this issue Mar 23, 2024

fix: Room - WS is not selected when filtered from newdot. #38861

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 23, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024

melvin-bot bot changed the title ~~[$500] Room - WS is not shown empty on setting collect WS as default.~~ [HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. Apr 8, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2024

MitchExpensify closed this as completed Apr 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. #37656

[HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. #37656

lanitochka17 commented Mar 2, 2024 •

edited by MitchExpensify

Loading

melvin-bot bot commented Mar 2, 2024

lanitochka17 commented Mar 2, 2024

allgandalf commented Mar 3, 2024

MitchExpensify commented Mar 3, 2024

Krishna2323 commented Mar 4, 2024 •

edited

Loading

Krishna2323 commented Mar 4, 2024

Bug Video

MitchExpensify commented Mar 6, 2024

Krishna2323 commented Mar 8, 2024

allgandalf commented Mar 8, 2024 •

edited

Loading

MitchExpensify commented Mar 10, 2024

Krishna2323 commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

MitchExpensify commented Mar 16, 2024

melvin-bot bot commented Mar 16, 2024

melvin-bot bot commented Mar 16, 2024

melvin-bot bot commented Mar 16, 2024

hoangzinh commented Mar 21, 2024

hoangzinh commented Mar 21, 2024

melvin-bot bot commented Mar 21, 2024

Krishna2323 commented Mar 23, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

MitchExpensify commented Apr 9, 2024

MitchExpensify commented Apr 15, 2024

Krishna2323 commented Apr 15, 2024

melvin-bot bot commented Apr 15, 2024

MitchExpensify commented Apr 15, 2024

hoangzinh commented Apr 17, 2024

hoangzinh commented Apr 17, 2024

hoangzinh commented Apr 19, 2024

MitchExpensify commented Apr 22, 2024

[HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. #37656

[HOLD for payment 2024-04-15] [$500] Room - WS is not shown empty on setting collect WS as default. #37656

Comments

lanitochka17 commented Mar 2, 2024 • edited by MitchExpensify Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 2, 2024

lanitochka17 commented Mar 2, 2024

allgandalf commented Mar 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result:

MitchExpensify commented Mar 3, 2024

Krishna2323 commented Mar 4, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Bug Video

What changes do you think we should make in order to solve the problem?

Result

Alternative

Krishna2323 commented Mar 4, 2024

Bug Video

MitchExpensify commented Mar 6, 2024

Krishna2323 commented Mar 8, 2024

allgandalf commented Mar 8, 2024 • edited Loading

MitchExpensify commented Mar 10, 2024

Krishna2323 commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

MitchExpensify commented Mar 16, 2024

Expected Result:

melvin-bot bot commented Mar 16, 2024

melvin-bot bot commented Mar 16, 2024

melvin-bot bot commented Mar 16, 2024

hoangzinh commented Mar 21, 2024

hoangzinh commented Mar 21, 2024

melvin-bot bot commented Mar 21, 2024

Krishna2323 commented Mar 23, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

MitchExpensify commented Apr 9, 2024

MitchExpensify commented Apr 15, 2024

Krishna2323 commented Apr 15, 2024

melvin-bot bot commented Apr 15, 2024

Payment Summary

BugZero Checklist (@MitchExpensify)

MitchExpensify commented Apr 15, 2024

hoangzinh commented Apr 17, 2024

Regression Test Proposal

hoangzinh commented Apr 17, 2024

BugZero Checklist:

hoangzinh commented Apr 19, 2024

MitchExpensify commented Apr 22, 2024

lanitochka17 commented Mar 2, 2024 •

edited by MitchExpensify

Loading

Krishna2323 commented Mar 4, 2024 •

edited

Loading

allgandalf commented Mar 8, 2024 •

edited

Loading