[HOLD for payment 2024-04-23] [$500] [Performance] Decouple draft state computation from report

[muttmuure]

Problem

Whenever a user starts to type a new message in Composer, the hasDraft state inside current Report object needs to be updated. The state is later used in LHN to determine if a draft indicator (pencil icon) should be displayed.

Calculations performed by the app to acquire updated hasDraft state are costly. It is caused by the fact that the hasDraft state is a property of a Report object which is then part of the entire list of reports user has access to (14k on testing account). Change of a single report causes list to be invalidated, making costly calculations of getOrderedReportIDs inside SidebarLinksData (component that resides on top of LHN) to run again.

❗ The getOrderedReportIDs calculations might take a few hundred ms, up to a few seconds depending on device and number of reports passed to the function. It is a severe execution overhead, considering how often user starts typing new message during regular conversation.

Solution

The hasDraft state can be decoupled from Report object and stored as an individual entry (or list of entries for many reports) under separate Onyx key. Such a solution should help us avoid invalidating the entire list of reports on every new message being typed, thus not triggering costly re-calculation of getOrderedReportIDs.

In Onyx, the REPORT_DRAFT_COMMENT key exists and serves similar purpose as hasDraft. Considering how hasDraft is used (to display draft indicator) it should not be an issue to re-use REPORT_DRAFT_COMMENT key for such functionality. It is mostly an implementation detail, but this way we are reducing app complexity and state redundancy.

From : @kacper-mikolajczak here

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012397339f4d656420
• Upwork Job ID: 1777386978362355712
• Last Price Increase: 2024-04-20

[mountiny]

@kacper-mikolajczak can you comment here?

[kacper-mikolajczak]

Yessir! @mountiny

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shubham1206agra]

Please assign me here as C+

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012397339f4d656420

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@AndrewGable, @shubham1206agra, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kacper-mikolajczak]

Melvin, PR was merged already

[shubham1206agra]

@mountiny Can you bump the price of this issue to $500, as this issue was created before the change?
And can you get this issue ready for payment?

[melvin-bot]

Upwork job price has been updated to $500

[melvin-bot]

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[mountiny]

I am fine with the price as it was complex change and it was made before the price change too.

$500 to @shubham1206agra once ready @dylanexpensify

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
• Contributor: @kacper-mikolajczak is from an agency-contributor and not due payment

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1777386978362355712/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dylanexpensify]

@shubham1206agra sent invite to apply!

[shubham1206agra]

@dylanexpensify Accepted

[dylanexpensify]

@shubham1206agra offer sent!

[shubham1206agra]

@dylanexpensify Offer accepted

[dylanexpensify]

Done!