Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones #39853

Closed
1 of 6 tasks
kbecciv opened this issue Apr 8, 2024 · 23 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a report
  3. Enter any text ( randomly try to type all letters, use number keypad, symbols, try to type using everything randomly.
  4. Try to remove entered text by tapping delete button

Expected Result:

Users should be able to enter and delete text seamlessly without experiencing any lag or issues with the keypad.

Actual Result:

The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442526_1712593771554.zi.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d3feefbbbfd76990
  • Upwork Job ID: 1777444404446453760
  • Last Price Increase: 2024-04-22
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

We think that this bug might be related to #vip-vsb

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

I am not sure if I follow exactly what is happening in the video

@kbecciv @isagoico @kavimuru Is this reliably repro on all android native and not on other platforms?

cc @tomekzaw @Skalakid @BartoszGrajdek as ti might be related to the markdown

@jasperhuangg
Copy link
Contributor

@mountiny It seems like there's a pretty large delay between when a key is tapped and when the input shows up in the composer.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 8, 2024

At first glance, the changes from #37281 seem like a good candidate for this issue. It modifies how we update report drafts as a user is typing in the composer.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 8, 2024

@mountiny

related to the markdown

Do you have any specific markdown related PRs that you are thinking of? I'm not finding any PRs on the deploy checklist related to markdown updates. Perhaps the issue stems from a markdown PR but doesn't happen without the changes from #37281?

Looking at the video again it feels like your hunch is correct since the delay only happens when typing characters that could trigger live markdown.

@kbecciv kbecciv changed the title Android - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones mWeb - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones Apr 8, 2024
@jasperhuangg
Copy link
Contributor

@kbecciv This only happens on Redmi phones? Do you have any other Android devices that you can test this with?

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

@mountiny @jasperhuangg
I'm going to request a test with a few different devices and environments, will update you shortly!

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

@jasperhuangg I believe that draft PR mainly changed how/ where we store whether a report has a draft but it should not have affected the actual typing experience of the content of the draft being saved.

It would be great to specify on what platforms/ devices this can be reliably repro-ed but if its platform specific ti feels more related to the markdown feature, rather than the draft PR.

cc @shubham1206agra @TMisiukiewicz for visibility

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

Issue isn't not reproduced on Pixel 6 / Chrome and SG21/Chrome, nor on any other devices.

video_2024-04-08_16-23-00.mp4

I believe this issue is specific to Redmi phones, as we've had two testers reproduce it.

@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

@jasperhuangg I suggest removing the DB label and expoerting this issue if that is the case

@jasperhuangg jasperhuangg added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title mWeb - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones [$250] mWeb - Chat - The keypad lagging, making it difficult to type or delete characters accurately in Redmi phones Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d3feefbbbfd76990

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

Copy link

melvin-bot bot commented Apr 8, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@jasperhuangg
Copy link
Contributor

Removing blocker label because this only happens on very specific Android devices and doesn't appear to be linked to any of the PRs that are currently on staging.

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@jasperhuangg
Copy link
Contributor

Still waiting on proposals on this one

Copy link

melvin-bot bot commented Apr 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Apr 15, 2024

@ntdiary, @twisterdotcom, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@jasperhuangg
Copy link
Contributor

Still waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 15, 2024
@jasperhuangg
Copy link
Contributor

Same ^

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 18, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@twisterdotcom
Copy link
Contributor

Is this bug specific to certain devices? If so, I'm going to close. Like there is no way this is a stock keyboard right?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants