[HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] Bank account - "Connect online with Plaid" is less indented than "Connect manually"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > any workspace
3. Go to Bank account

Expected Result:

"Connect online with Plaid" will have the same indentation like "Connect manually"

Actual Result:

"Connect online with Plaid" is less indented than "Connect manually"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[lanitochka17]

@youssef-lr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[brunovjk]

It looks like it was caused by this PR, I reverted this commit and the issue is no longer reproducible.

[narefyev91]

Please check this comment #37966 (comment)
cc @shawnborton @Expensify/design

[shawnborton]

Hmm okay yeah, I was afraid of something like this. @narefyev91 can we fix the button in this case to look like production? I think we need to make an exception in this case since this isn't really a standard button, but rather, it's trying to be a "green" option row.

[narefyev91]

Hmm okay yeah, I was afraid of something like this. @narefyev91 can we fix the button in this case to look like production? I think we need to make an exception in this case since this isn't really a standard button, but rather, it's trying to be a "green" option row.

Sure - will do it

[luacmartins]

This is fixed in staging

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix icons after regression #38275

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix icons after regression #38275

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)