-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-05] [$500] Storybook - "Couldn't find a navigation object" error when trying to select a year #38331
Comments
Triggered auto assignment to @anmurali ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Storybook - "Couldn't find a navigation object" error when trying to select a year What is the root cause of that problem?We need to wrap App/src/stories/Form.stories.tsx Lines 53 to 54 in d4eaf4e
What changes do you think we should make in order to solve the problem?Wrap There might be more components which uses navigation and is used in storrybook, we might want to check for that as well. Resultstorybook_fix.mp4AlternativeWrap |
Job added to Upwork: https://www.upwork.com/jobs/~01a13cfaecad01b349 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Remedy the "Couldn't find a navigation object" error when trying to select a year What is the root cause of that problem?Components like StatePicker and DatePicker require a navigation context; however, in Storybook, this navigation context is not naturally present. What changes do you think we should make in order to solve the problem?Provide navigation context, thus preventing the error when these components try to access navigation-related features. |
ProposalPlease re-state the problem that we are trying to solve in this issue."Couldn't find a navigation object. Is your component inside NavigationContainer?" error when trying to select a year or state. What is the root cause of that problem?In What changes do you think we should make in order to solve the problem?Except for the We need to:
If we want to keep this logic, then we should pass
What alternative solutions did you explore? (Optional)Alternate for 2:
We should also double check other pages to see if there's any similar problem, and fix similarly. |
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@dukenv0307, are you sure that the navigation added in |
@Krishna2323 Let's see the detail implementation of App/src/hooks/useWaitForNavigation.ts Lines 28 to 31 in 22bd9eb
We just exectute
But for now, we don't use Pls let me know if you still have some confused points |
Can you pls explain what do you mean by |
@Krishna2323 We defined it as the prop here. But we don't pass |
FYI I've explained the history of that prop pretty clearly in the proposal,
Feel free to highlight if you find any actual downside of removing it. |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR ready for review #38659. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BugZero Checklist:
N/A
N/A
N/A
We don't need to create a regression test
No |
@dukenv0307 and @tienifr have been paid. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.52.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #37820
Action Performed:
Expected Result:
I should be able to select a year and state
Actual Result:
"Couldn't find a navigation object. Is your component inside NavigationContainer?" error when trying to select a year or state.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6413512_1710421119535.bandicam_2024-03-14_13-58-02-469.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: