[HOLD for payment 2024-04-15] [$250] Bank account - Company's website field is missing https://

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > any workspace.
3. Go to Bank account > Connect manually.
4. Proceed until Company's website step.

Expected Result:

Company website field will have https://
in the field by default (production behavior).

Actual Result:

Company website field does not have https://
in the field. The field is empty.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6419158_1710850301608.bandicam_2024-03-19_20-08-41-501.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166d2a81ddf61dab7
• Upwork Job ID: 1772294434143510528
• Last Price Increase: 2024-03-25
• Automatic offers:
• dukenv0307 | Reviewer | 0
• tienifr | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company website field does not have https://
in the field. The field is empty.

What is the root cause of that problem?

Here's the PR that cause this issue
We reset website to empty string in here, it was undefined before

-> the inputValues is init with empty string

What changes do you think we should make in order to solve the problem?

Solution 1:
We should use the same logic here to init the website when users reset bank account website

Solution 2:
We can update the CompanyStepProps and Form tyep to allow undefined

What alternative solutions did you explore? (Optional)

NA

[aimane-chnaif]

@tienifr that root cause was to make Typescript happy.
@mateuuszzzzz can you please check this?

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Company's website field is missing https://

What is the root cause of that problem?

Here :

App/src/pages/ReimbursementAccount/BusinessInfo/substeps/WebsiteBusiness.tsx

Lines 51 to 55 in e34f10e

	const defaultWebsiteExample = useMemo(
	() => (user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`),
	[session?.email, user?.isFromPublicDomain],
	);
	const defaultCompanyWebsite = reimbursementAccount?.achData?.website ?? defaultWebsiteExample;

because of empty string the website field is empty.

What changes do you think we should make in order to solve the problem?

We can remove defaultWebsiteExample completely and add this :

const defaultCompanyWebsite = 'https://';

this will show https://

What alternative solutions did you explore? (Optional)

const defaultCompanyWebsite = reimbursementAccount?.achData?.website || defaultWebsiteExample;

Result

Screen.Recording.2024-03-19.at.8.43.04.PM.mov

[ghost]

Updated Proposal

[cristipaval]

I'm demoting this one as NAB given that it is a minor UI issue. We have the URL validation so the user can't add invalid data 🤷‍♂️

[cristipaval]

@mateuuszzzzz would you work to fix this one?

[cristipaval]

I'm also adding @aimane-chnaif as the C+ since he was also assigned to the original PR

[ghost]

Hey @cristipaval how about my proposal?

[aimane-chnaif]

Sorry I wanted to review this but had to unassign as I'll be OOO from tomorrow

[dukenv0307]

@cristipaval I'm a new C+ so I'm low on issues, I can take over 👍

[ghost]

Hey @dukenv0307 can you please review my proposal? and congrats on new C+

[ghost]

But according to this comment. @tienifr 's RCA was to make Typescript happy that was stated by @aimane-chnaif

[dukenv0307]

Yes, but we can update default website to https:// without updating any TS type

[allgandalf]

@tienifr take care of the edge case where user removes https://, the draft value should be a empty input box in that case right 🤔

[ghost]

Can you check my working video ? or I can post a working video for your reference @dukenv0307

[dukenv0307]

@godofoutcasts94 I checked your video but I don't think removing defaultWebsiteExample is safe, and the RCA you mentioned is not correct, reimbursementAccount?.achData?.website is undefined. Pls check my comment here

[shubham1206agra]

@cristipaval Shouldn't this be handled by @mateuuszzzzz, as this is a regression from #36495?

[dukenv0307]

@cristipaval Can you help check my decision here? Thanks

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cristipaval]

Thanks @dukenv0307!
Assigning @tienifr to not disturb @mateuuszzzzz from wave work.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix company website field missing https #39162

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[puneetlath]

All paid. Thanks everyone.